Page MenuHomeFreeBSD

math/py-kiwisolver: Update to 1.2.0
ClosedPublic

Authored by lbartoletti on Apr 11 2020, 6:36 AM.

Details

Summary
  • Update math/py-kiwisolver to 1.2.0
  • Version 1.1.0 of math/py-kiwisolver was the last one to support Pyton2. Now, it's python 3.6+ only
  • Strip kiwisolver.so
  • Add a new port devel/py-cppy as dependency [1]
Test Plan
  • portlint (looks fine.)
  • poudriere (11/12/13 i386/amd64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

math/py-kiwisolver/Makefile
15 ↗(On Diff #70427)

^ are you sure about allfalvors

#       allflavors      - Generate flavors for all possible versions and not
#                         simply the default ones.  Only to be used for py-*
#                         ports that are part of the Python distribution, but
#                         kept as separate ports.
lbartoletti added inline comments.
math/py-kiwisolver/Makefile
15 ↗(On Diff #70427)

Nope, I asked on #freebsd-python

I never paid attention to this line in python.mk because from what I understand the handbook https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#flavors-auto-python, it's not reserved for special ports. And it's the only way to allow to build py38 ports where default python is py37 for example.

lbartoletti marked an inline comment as done.

Remove allflavors

Remove allflavors

@mat could you clarify the use of allflavors -- what is correct, the porters handbook or python.mk?

Remove allflavors

@mat could you clarify the use of allflavors -- what is correct, the porters handbook or python.mk?

Erg. I forgot to post the exchange we had with @koobs on irc.

lbart: allflavors is for in-ports use, and again only for special (not general) use
lbart: for users, the current knob is BUILD_ALL_PYTHON_FLAVORS, which aside from being opt-in to allow more than just default-version building, is not particularly well named
lbart: so either stick that in the respective make.conf or provide it on the command line in the form of make arg or env var

This revision is now accepted and ready to land.Apr 29 2020, 7:13 PM

Should I commit devel/py-cppy first as a new port and after math/py-kiwisolver or both in the same commit?

Should I commit devel/py-cppy first as a new port and after math/py-kiwisolver or both in the same commit?

I would go with two commit's here.

  1. One to create the new port
  2. The second with he update