Page MenuHomeFreeBSD

riscv: Fix pmap_fault_fixup for L3 pages
ClosedPublic

Authored by jrtc27 on Apr 6 2020, 8:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 3 2024, 10:34 AM
Unknown Object (File)
Sep 24 2024, 7:04 PM
Unknown Object (File)
Sep 24 2024, 12:44 AM
Unknown Object (File)
Sep 20 2024, 7:20 PM
Unknown Object (File)
Sep 8 2024, 3:52 AM
Unknown Object (File)
Sep 7 2024, 12:31 PM
Unknown Object (File)
Sep 5 2024, 2:33 PM
Unknown Object (File)
Aug 29 2024, 6:48 AM
Subscribers

Details

Summary

The parentheses being in the wrong place means that, for L3 pages,
oldpte has all bits except PTE_V cleared, and so all the subsequent
checks against oldpte will fail, causing us to bail out and not retry
the faulting instruction after an SFENCE.VMA. This causes a WITNESS +
INVARIANTS kernel to fault on the "Chisel P3" (BOOM-based) DARPA SSITH
GFE SoC in pmap_init when writing to pv_table and, being a nofault
entry, subsequently panic with:

panic: vm_fault_lookup: fault on nofault entry, addr: 0xffffffc004e00000

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable