Bhyve: SMBIOS bcdrev calculated from major/minor values
ClosedPublic
Actions

Authored by rgrimes on Apr 5 2020, 10:25 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 7, 7:52 PM

	Unknown Object (File)
	Wed, Oct 7, 7:52 PM

	Unknown Object (File)
	Wed, Oct 7, 7:52 PM

	Unknown Object (File)
	Wed, Oct 7, 7:51 PM

	Unknown Object (File)
	Tue, Oct 6, 3:59 PM

	Unknown Object (File)
	Mon, Sep 28, 5:53 PM

	Unknown Object (File)
	Mon, Sep 28, 5:50 PM

	Unknown Object (File)
	Mon, Sep 28, 4:20 PM

View All Files

Subscribers

None

Details

Reviewers

bcran
grehan
jhb

Group Reviewers

bhyve

Summary

In the past changes have been made to smbios->minor without updating the smbios->bcdrev value. Correct that by calculating bcdrev from the major/minor values.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

rgrimes created this revision.Apr 5 2020, 10:25 AM

bcran accepted this revision.Apr 5 2020, 5:51 PM

This revision is now accepted and ready to land.Apr 5 2020, 5:51 PM

jhb accepted this revision.Apr 6 2020, 4:39 PM

jhb added inline comments.

usr.sbin/bhyve/smbiostbl.c
771	If you want the comment, please style(9) it by adding a blank line before and a period. I think you could probably also get away with not needing the comment since the code is a few lines below and fairly obvious.

Remove comment

This revision now requires review to proceed.Apr 7 2020, 11:15 PM

rgrimes marked an inline comment as done.Apr 7 2020, 11:15 PM

bcran accepted this revision.Apr 8 2020, 3:24 AM

This revision is now accepted and ready to land.Apr 8 2020, 3:24 AM

This was fixed in rS359719, so I think this review should be closed.

jhb closed this revision.Dec 30 2020, 9:37 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

	smbiostbl.c
	smbiostbl.c.orig

2 lines

Diff 70324

View Options

usr.sbin/bhyve/smbiostbl.c

Bhyve: SMBIOS bcdrev calculated from major/minor valuesClosedPublicActions