Page MenuHomeFreeBSD

Bhyve: SMBIOS bcdrev calculated from major/minor values
AcceptedPublic

Authored by rgrimes on Apr 5 2020, 10:25 AM.

Details

Reviewers
bcran
grehan
jhb
Group Reviewers
bhyve
Summary

In the past changes have been made to smbios->minor without updating the smbios->bcdrev value. Correct that by calculating bcdrev from the major/minor values.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Apr 5 2020, 5:51 PM
jhb added inline comments.
usr.sbin/bhyve/smbiostbl.c
771

If you want the comment, please style(9) it by adding a blank line before and a period. I think you could probably also get away with not needing the comment since the code is a few lines below and fairly obvious.

This revision now requires review to proceed.Apr 7 2020, 11:15 PM
This revision is now accepted and ready to land.Apr 8 2020, 3:24 AM