fix users of cn_flags for 64 bits

[sigsys_gmail.com]

Summary

namei's componentname struct has a cn_flags field that was changed to 64 bits at some point to allow for more flags, but some users of this field still treat it as an int (or sometimes long).

This patch fixes all of those that I could find.

I added the ULL suffix to the individual flag macro literals to make masking operations just work.

I changed some variables to bool but I was careful to do so in a way that would still work if bool is typedef'd to int.

[sigsys_gmail.com]

Updated to use uint64_t instead of u_int64_t. No other changes.

[kib]

sys/sys/namei.h

193

Does the op arg need to be long ?

[markj]

sys/fs/fuse/fuse_vnops.c

984–986

I would make wantparent and islastcn into bools as well:

bool wantparent = (flags & (LOCKPARENT | WANTPARENT)) != 0;
bool islastcn = (flags & ISLASTCN) != 0;

just to explicitly avoid narrowing.

sys/fs/smbfs/smbfs_vnops.c

1199

Same as above regarding the use of a bool.

[sigsys_gmail.com]

sys/fs/fuse/fuse_vnops.c

984–986

Oops missed those ones. I'll update the diff.

sys/sys/namei.h

193

I can't see any reason it would need to be. It gets saved in int variables too sometimes.

But I just noticed an assert in vfs_lookup.c that checks if cn_nameiop gets "contaminated" with flags, so if the op is larger it allows to detect more errors like this.

[sigsys_gmail.com]

Change some ints to bools in fuse_vnops.c. No other changes.

[sigsys_gmail.com]

Change some more variables to bool in smbfs_vnops.

[sigsys_gmail.com]

sys/fs/smbfs/smbfs_vnops.c

1199

The two other variables could be changed to bool too. It seemed a bit silly not to do it since they're declared together.