Page MenuHomeFreeBSD

powerpc/booke: Use power-of-two mappings in 64-bit pmap_mapdev
ClosedPublic

Authored by jhibbits on Apr 1 2020, 2:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 1:38 PM
Unknown Object (File)
Thu, Nov 14, 9:36 AM
Unknown Object (File)
Oct 4 2024, 7:39 AM
Unknown Object (File)
Oct 1 2024, 11:22 AM
Unknown Object (File)
Sep 21 2024, 3:57 AM
Unknown Object (File)
Sep 4 2024, 11:18 PM
Unknown Object (File)
Aug 31 2024, 1:25 PM
Unknown Object (File)
Aug 19 2024, 10:49 AM
Subscribers

Details

Summary

This reduces the precious TLB1 entry consumption (64 possible in
existing 64-bit cores), by adjusting the size and alignment of a device
mapping to a power of 2, to encompass the full mapping and its
surroundings.

One caveat with this: If a mapping really is smaller than a power of 2,
it's possible to get a machine check or hang if the 'missing' physical
space is accessed. In practice this should not be an issue for users,
as devices overwhelmingly have physical spaces on power-of-two sizes and
alignments, and any design that includes devices which don't follow this
can be addressed by undefining the POW2_MAPPINGS guard.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 30225
Build 28010: arc lint + arc unit

Event Timeline

Works for me on RB800 and X5000.

sys/powerpc/booke/pmap.c
2625

Does this need ::: "memory" or does clang pick up on the side effects already?

This revision is now accepted and ready to land.Apr 10 2020, 9:37 PM