Ensure pkg-devel package is built with default pkg
ClosedPublic
Actions

Authored by bapt on Mar 3 2020, 12:00 PM.

Details

Reviewers

bdrewery
bapt

Group Reviewers

portmgr

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29757
Build 27595: arc lint + arc unit

Event Timeline

bapt created this revision.Mar 3 2020, 12:00 PM

Herald added a reviewer: bdrewery. · View Herald TranscriptMar 3 2020, 12:00 PM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B29754: Diff 69113.Mar 3 2020, 12:00 PM

When does the case !exists(${LOCALBASE}/sbin/pkg) && !defined(CROSS_TOOLCHAIN) happen that is also not when WITH_PKG=devel?

In D23939#526145, @mat wrote:

When does the case !exists(${LOCALBASE}/sbin/pkg) && !defined(CROSS_TOOLCHAIN) happen that is also not when WITH_PKG=devel?

When I do build locally with make package for example.

Before running in poudriere, I usually first do some make WITH_PKG=devel clean all check-plist package

kevans added a subscriber: kevans.Mar 3 2020, 1:38 PM

kevans added inline comments.

ports-mgmt/pkg-devel/Makefile
52	WITH_PKG can be undefined when this is evaluated, can't it? (Observation from the just previous use a little further up)

bapt retitled this revision from Encore pkg-devel package is built with default pkg to Ensure pkg-devel package is built with default pkg.Mar 3 2020, 2:02 PM

bapt marked an inline comment as done.Mar 3 2020, 2:05 PM

bapt added inline comments.

ports-mgmt/pkg-devel/Makefile
52	WITH_PKG is always defined by the framework.

In D23939#526167, @bapt wrote:

In D23939#526145, @mat wrote:

When does the case !exists(${LOCALBASE}/sbin/pkg) && !defined(CROSS_TOOLCHAIN) happen that is also not when WITH_PKG=devel?

When I do build locally with make package for example.

Before running in poudriere, I usually first do some make WITH_PKG=devel clean all check-plist package

Mmmm, ok, let me rephrase.

In which case is !exists(${LOCALBASE}/sbin/pkg) && !defined(CROSS_TOOLCHAIN) false, exactly?

In D23939#526145, @mat wrote:

When does the case !exists(${LOCALBASE}/sbin/pkg) && !defined(CROSS_TOOLCHAIN) happen that is also not when WITH_PKG=devel?

hum you are right