x11/libwacom: unbreak after rP244554 when libxml2 isn't bootlegged
ClosedPublic
Actions

Authored by jbeich on Mar 2 2020, 6:39 PM.

Details

Reviewers

Group Reviewers

x11

Commits

Summary

Test Plan

Builds fine on:

Runtime testing is not required as tests are not installed.

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29736
Build 27575: arc lint + arc unit

LGTM.
Thanks

This revision is now accepted and ready to land.Mar 4 2020, 8:24 AM

seems sane and low risk of breaking other things.

LGTM

This revision was automatically updated to reflect the committed changes.

rfyu28uyeg_snkmail.com added inline comments.

x11/libwacom/Makefile
14	Making libxml2 (these patches) optional is okay. A separate commit would be worthwhile to get 'make test' working (which should then include TEST_DEPENDS for libxml2).
x11/libwacom/distinfo
9	Can you please put anonymous patch files such as these in a "libwacom" DIST_SUBDIR?

x11/libwacom/Makefile
14	`make test` not working is not a regression. `USES=meson` implicitly defines `TEST_TARGET` but tests could be run even before rP527162 e.g., $ make test TEST_TARGET=check gmake[3]: Entering directory '/usr/ports/x11/libwacom/work/libwacom-libwacom-0.32/data/layouts' /bin/sh: Syntax error: Bad fd number
x11/libwacom/distinfo
9	These patches are ephemeral i.e., to be removed on the next update. However, DIST_SUBDIR only works for all distfiles.