Paths

Table of Contentst

Differential D23863

Add EVDEV_SUPPORT to acpi_button and acpi_lid
ClosedPublic
Actions

Authored by • hselasky on Feb 27 2020, 10:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 3, 8:32 PM

	Unknown Object (File)
	Oct 23 2024, 1:13 PM

	Unknown Object (File)
	Oct 20 2024, 9:14 AM

	Unknown Object (File)
	Oct 20 2024, 8:07 AM

	Unknown Object (File)
	Sep 21 2024, 8:39 PM

	Unknown Object (File)
	Sep 16 2024, 9:57 PM

	Unknown Object (File)
	Sep 16 2024, 9:57 PM

	Unknown Object (File)
	Sep 16 2024, 9:57 PM

View All 56 Files

Subscribers

Details

Reviewers

cem
val_packett.cool

Group Reviewers

Contributor Reviews (src)

Commits

rS358884: MFC r358537:
rS358883: MFC r358537:
rS358537: Expose the ACPI power button, sleep button and LID state as evdev's.

Summary

On Linux, these ACPI devices are exposed as evdev. This is useful for a bunch of things — libinput disables touchpads when the lid is closed, various DEs can show power-off dialogs when the power is pressed, etc. (While the latter should be doable with devd, a cross-platform solution is nicer.)

Test Plan

Tested libinput's touchpad disablement on my Pixelbook.

Couldn't test acpi_button: the Pixelbook power button is part of the *keyboard*, while on my desktop the button is not getting to that code for some reason.. (no devd event either)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Feb 27 2020, 10:06 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2020, 10:06 PM

added diff context

• hselasky added inline comments.Feb 27 2020, 10:37 PM

sys/dev/acpica/acpi_lid.c
119 ↗	(On Diff #68919)	Can you test this w/ suspend and resume.

Mostly style nits and an init order fix in case of error.

Harbormaster completed remote builds in B29719: Diff 69058.Mar 2 2020, 9:43 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2020, 9:45 AM

Closed by commit rS358537: Expose the ACPI power button, sleep button and LID state as evdev's. (authored by • hselasky). · Explain Why

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rS358537: Expose the ACPI power button, sleep button and LID state as evdev's..

• hselasky added a commit: rS358883: MFC r358537:.Mar 11 2020, 8:32 AM

• hselasky added a commit: rS358884: MFC r358537:.Mar 11 2020, 8:34 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

acpica/

34 lines

29 lines

Diff 69059

head/sys/dev/acpica/acpi_button.c

Loading...

head/sys/dev/acpica/acpi_lid.c

Loading...