Paths

Table of Contentst

Differential D23798

sys/kern: quiet -Wwrite-strings
ClosedPublic
Actions

Authored by rlibby on Feb 22 2020, 9:49 PM.

Tags

None

Referenced Files

	F138035188: D23798.id68687.diff
	Fri, Nov 28, 9:34 AM

	Unknown Object (File)
	Wed, Nov 26, 9:54 AM

	Unknown Object (File)
	Thu, Nov 20, 5:14 PM

	Unknown Object (File)
	Thu, Nov 20, 5:10 PM

	Unknown Object (File)
	Thu, Nov 20, 4:43 PM

	Unknown Object (File)
	Thu, Nov 20, 4:36 PM

	Unknown Object (File)
	Wed, Nov 12, 2:27 AM

	Unknown Object (File)
	Mon, Nov 10, 9:52 PM

View All 77 Files

Subscribers

Details

Reviewers

kib
markj

Commits

rS358258: sys/kern: quiet -Wwrite-strings

Summary

Quiet a variety of Wwrite-strings warnings in sys/kern at low-impact
sites. This patch avoids addressing certain others which would need to
plumb const through structure definitions.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Feb 22 2020, 9:49 PM

Harbormaster completed remote builds in B29537: Diff 68687.Feb 22 2020, 9:49 PM

markj accepted this revision.Feb 22 2020, 10:11 PM

This revision is now accepted and ready to land.Feb 22 2020, 10:11 PM

kib accepted this revision.Feb 22 2020, 10:25 PM

kib added inline comments.

sys/kern/kern_cons.c
101 ↗	(On Diff #68687)	Make this static const char [] ? What is the point of the additional indirection ?
sys/kern/kern_linker.c
1768 ↗	(On Diff #68687)	Again `const char * const` ?

Closed by commit rS358258: sys/kern: quiet -Wwrite-strings (authored by rlibby). · Explain WhyFeb 23 2020, 3:32 AM

This revision was automatically updated to reflect the committed changes.

rlibby marked 2 inline comments as done.

rlibby added a commit: rS358258: sys/kern: quiet -Wwrite-strings.

Herald added a subscriber: imp. · View Herald TranscriptFeb 23 2020, 3:32 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

6 lines

8 lines

kern_shutdown.c

2 lines

2 lines

2 lines

sys/

2 lines

2 lines

2 lines

2 lines

Diff 68695

head/sys/kern/kern_cons.c

Loading...

head/sys/kern/kern_linker.c

Loading...

head/sys/kern/kern_shutdown.c

Loading...

head/sys/kern/kern_sig.c

Loading...

head/sys/kern/link_elf.c

Loading...

head/sys/sys/bufobj.h

Loading...

head/sys/sys/conf.h

Loading...

head/sys/sys/cons.h

Loading...

head/sys/sys/signalvar.h

Loading...