Page MenuHomeFreeBSD
Differential D23733

Teach libsysdecode/kdump/truss about shm_open2
ClosedPublic
Actions

Authored by kevans on Feb 17 2020, 7:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 18 2024, 5:18 PM
Unknown Object (File)
Dec 20 2023, 1:46 AM
Unknown Object (File)
Dec 4 2023, 5:27 PM
Unknown Object (File)
Dec 1 2023, 11:18 AM
Unknown Object (File)
Nov 29 2023, 6:23 AM
Unknown Object (File)
Aug 14 2023, 4:36 AM
Unknown Object (File)
Jul 22 2023, 5:01 AM
Unknown Object (File)
Jul 7 2023, 6:22 AM
View All 13 Files
Subscribers
imp

Details

Reviewers
jhb
kaktus
Commits
rS358115: libsysdecode: grab shmflags from sys/mman.h, add decode method
Summary

This fixes shm_open() decoding on recent -HEAD, which is now implemented as a C wrapper for shm_open2().

Test Plan

truss excerpt:

shm_open2(SHM_ANON,O_RDWR|O_CLOEXEC,00,SHM_ALLOW_SEALING,0x7fffffffe980) = 3 (0x3)

kdump excerpt:

40660 a.out    CALL  shm_open2(0x1,0x100002<O_RDWR|O_CLOEXEC>,0,0x1<SHM_ALLOW_SEALING>,0x7fffffffe990)
40660 a.out    RET   shm_open2 3

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Feb 17 2020, 7:24 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2020, 7:24 PM
Harbormaster completed remote builds in B29453: Diff 68467.Feb 17 2020, 7:24 PM
kevans updated this revision to Diff 68470.Feb 17 2020, 7:45 PM
kevans edited the test plan for this revision. (Show Details)

Decode shmflags in truss, too

Harbormaster completed remote builds in B29456: Diff 68470.Feb 17 2020, 7:45 PM
kaktus accepted this revision.Feb 19 2020, 2:06 PM

LGTM.

Although it'd be nice to decode the first argument in ktrace/kdump case just like truss does it here.

This revision is now accepted and ready to land.Feb 19 2020, 2:06 PM
Closed by commit rS358115: libsysdecode: grab shmflags from sys/mman.h, add decode method (authored by kevans). · Explain WhyFeb 19 2020, 2:52 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rS358115: libsysdecode: grab shmflags from sys/mman.h, add decode method.
kevans mentioned this in rS358116: truss: decode shm_open2.Feb 19 2020, 2:54 PM
kevans mentioned this in rS358117: kdump: decode shm_open2.

Revision Contents
Changeset List

PathSize
head/
lib/
libsysdecode/
7 lines
1 line
1 line

Diff 68525

View Options

head/lib/libsysdecode/flags.c

Loading...
View Options

head/lib/libsysdecode/mktables

Loading...
View Options

head/lib/libsysdecode/sysdecode.h

Loading...