Page MenuHomeFreeBSD

Add a manual page for smbios(4)
ClosedPublic

Authored by gbe on Feb 16 2020, 11:03 AM.

Details

Summary

Add a basic manual page for smbios(4)

PR: 240252, 163830

Test Plan

mandoc output review

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

brueffer added a subscriber: brueffer.

Looks good apart from the minor comments!

share/man/man4/smbios.4
1 ↗(On Diff #68402)

Please update the year.

27 ↗(On Diff #68402)

Please update the date before committing.

64 ↗(On Diff #68402)

Missing terminating "."

This revision now requires changes to proceed.Feb 16 2020, 2:45 PM
Address feedback by brueffer@
gbe marked 3 inline comments as done.Feb 16 2020, 2:57 PM

Thanks for the comments, I updated the diff accordingly.

This revision is now accepted and ready to land.Feb 16 2020, 3:03 PM
rpokala added inline comments.
share/man/man4/smbios.4
2 ↗(On Diff #68410)

In recent years, we have generally left out the "All rights reserved", as it is no longer needed.

  • Address Feedback by rpokala@
This revision now requires review to proceed.Feb 18 2020, 6:59 AM
gbe marked an inline comment as done.

I removed the "All Rights Reserved." as suggested by rpokala@.

This revision is now accepted and ready to land.Feb 18 2020, 7:01 AM
In D23714#534003, @gbergling_gmail.com wrote:

Ping?

As far as I can tell, there are no outstanding reviews. Are you pinging for someone to commit it on your behalf?

In D23714#534003, @gbergling_gmail.com wrote:

Ping?

As far as I can tell, there are no outstanding reviews. Are you pinging for someone to commit it on your behalf?

Yes, that was the reason for the ping. The problem is, I have for every open differential a complete cloned git repository and the I have a lot opened differentials and not so much diskspace.

This revision was automatically updated to reflect the committed changes.