Add a manual page for smbios(4)
ClosedPublic
Actions

Authored by gbe on Feb 16 2020, 11:03 AM.

Details

Reviewers

brueffer
gbe
rpokala

Group Reviewers

manpages

Commits

rS362724: MFC r359633, r359656, r360190: Add a manpage for smbios(4).
rS359633: Add a manpage for smbios(4).

Summary

Add a basic manual page for smbios(4)

PR: 240252, 163830

Test Plan

mandoc output review

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gbe created this revision.Feb 16 2020, 11:03 AM

Harbormaster completed remote builds in B29424: Diff 68402.Feb 16 2020, 11:03 AM

gbe edited the summary of this revision. (Show Details)Feb 16 2020, 11:08 AM

Looks good apart from the minor comments!

share/man/man4/smbios.4
1 ↗	(On Diff #68402)	Please update the year.
27 ↗	(On Diff #68402)	Please update the date before committing.
64 ↗	(On Diff #68402)	Missing terminating "."

This revision now requires changes to proceed.Feb 16 2020, 2:45 PM

Address feedback by brueffer@

Harbormaster completed remote builds in B29428: Diff 68410.Feb 16 2020, 2:55 PM

Thanks for the comments, I updated the diff accordingly.

brueffer accepted this revision.Feb 16 2020, 3:03 PM

This revision is now accepted and ready to land.Feb 16 2020, 3:03 PM

rpokala added a subscriber: rpokala.Feb 17 2020, 7:47 PM

rpokala added inline comments.

share/man/man4/smbios.4
2 ↗	(On Diff #68410)	In recent years, we have generally left out the "All rights reserved", as it is no longer needed.

Address Feedback by rpokala@

This revision now requires review to proceed.Feb 18 2020, 6:59 AM

Harbormaster completed remote builds in B29464: Diff 68480.Feb 18 2020, 6:59 AM

This revision is now accepted and ready to land.Feb 18 2020, 7:01 AM

rpokala accepted this revision as: rpokala.Feb 23 2020, 6:18 PM

Ping?

In D23714#534003, @gbergling_gmail.com wrote:

Ping?

As far as I can tell, there are no outstanding reviews. Are you pinging for someone to commit it on your behalf?

In D23714#534088, @rpokala wrote:

In D23714#534003, @gbergling_gmail.com wrote:

Ping?

As far as I can tell, there are no outstanding reviews. Are you pinging for someone to commit it on your behalf?

Yes, that was the reason for the ping. The problem is, I have for every open differential a complete cloned git repository and the I have a lot opened differentials and not so much diskspace.

Closed by commit rS359633: Add a manpage for smbios(4). (authored by brueffer). · Explain WhyApr 4 2020, 9:38 PM

This revision was automatically updated to reflect the committed changes.

brueffer added a commit: rS359633: Add a manpage for smbios(4)..

Herald added a subscriber: imp. · View Herald TranscriptApr 4 2020, 9:38 PM

gbe added a commit: rS362724: MFC r359633, r359656, r360190: Add a manpage for smbios(4)..Jun 28 2020, 2:37 PM