Page MenuHomeFreeBSD

www/redmine4: unbreak and update to 4.0.6
ClosedPublic

Authored by mikael on Feb 14 2020, 9:25 AM.

Details

Summary

Disable the RMAGIC option, it causes conflict with different versions of imagemagick. This problem is fixed in redmine 4.1, hopefully they'll backport the fix to the 4.0 branch.
Use the correct redmine version when building redmine plugins

I think we should deprecate redmine3, redmine40 has switched to rails52 which broke a lot of plugins.

Test Plan

testport, portlint ok

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

also, update the port to 4.0.6

Why not just upgrade the redmine4 port to the newest 4.x version available?
I'm not in favor creating new ports if it is not really necessary.

Why not just upgrade the redmine4 port to the newest 4.x version available?
I'm not in favor creating new ports if it is not really necessary.

The redmine project supports the last 2 versions (ie 4.0.x and 4.1.x). I have no objection to use the latest version.

The redmine project supports the last 2 versions (ie 4.0.x and 4.1.x). I have no objection to use the latest version.

if this is the case, I would upgrade www/redmine to the newest version and would remove the www/redmine4 port completely.
This makes it for the user much more simple which port to use.

mikael retitled this revision from www/redmine4: unbreak and rename to www/redmine4: unbreak and update to 4.0.6.
mikael edited the summary of this revision. (Show Details)

I tried to apply your patch against version 527099, but it fails with conflicts:

U         MOVED
>         applied hunk @@ -14250,3 +14250,4 @@ with offset -3
U         www/Makefile
>         applied hunk @@ -1831,7 +1831,7 @@ with offset 2
U         www/redmine4/Makefile
>         applied hunk @@ -35,8 +34,6 @@ with offset 2
>         applied hunk @@ -46,7 +43,7 @@ with offset 2
>         applied hunk @@ -62,6 +59,16 @@ with offset 2
U         www/redmine4/bsd.redmine.mk
U         www/redmine4/distinfo
D         www/redmine4/files/markdown.rb
D         www/redmine4/files/mysql.rb
U         www/redmine4/files/patch-Gemfile
D         www/redmine4/files/pg.rb
D         www/redmine4/files/redmine.in
D         www/redmine4/files/rmagic.rb
D         www/redmine4/files/thin.rb
D         www/redmine4/pkg-descr
D         www/redmine4/pkg-message
D         www/redmine4/pkg-plist
C         www/redmine40/Makefile
>         rejected hunk @@ -2,11 +2,10 @@
>         rejected hunk @@ -14,8 +13,6 @@
>         rejected hunk @@ -48,7 +45,7 @@
>         rejected hunk @@ -64,6 +61,16 @@
C         www/redmine40/bsd.redmine.mk
>         rejected hunk @@ -43,9 +43,9 @@
C         www/redmine40/distinfo
>         rejected hunk @@ -1,3 +1,3 @@
C         www/redmine40/files/patch-Gemfile
>         rejected hunk @@ -1,15 +1,13 @@
>         rejected hunk @@ -84,7 +82,7 @@
>         rejected hunk @@ -95,12 +93,11 @@
Summary of conflicts:
  Text conflicts: 4

Could you update the patch please, that it applies without conflicts?
Thanks.

Weird, it applies without conflicts here:

svn patch  D23682.diff
U         www/redmine4/Makefile
>         applied hunk @@ -35,8 +34,6 @@ with offset 2
>         applied hunk @@ -46,7 +43,7 @@ with offset 2
>         applied hunk @@ -62,6 +59,16 @@ with offset 2
U         www/redmine4/bsd.redmine.mk
U         www/redmine4/distinfo
U         www/redmine4/files/patch-Gemfile

I wonder why it tries to patch redmine40 in your case:

C         www/redmine40/Makefile

The redmine project supports the last 2 versions (ie 4.0.x and 4.1.x). I have no objection to use the latest version.

if this is the case, I would upgrade www/redmine to the newest version and would remove the www/redmine4 port completely.
This makes it for the user much more simple which port to use.

Please do not replace current www/redmine (3.4) with the new 4.0 version. Many plugins are not compatible. It will do more harm to the users than having two ports to choose from. Create www/redmine4 or if you feel necessary to have 4.0 as www/redmine then please move current 3.4 version in to www/redmine3. This has precedence in other ports too. For example postfix.

As of supported versions - all 3 branches released latest version at the same day:

  • 4.1.0 (2019-12-20)
  • 4.0.6 (2019-12-20)
  • 3.4.13 (2019-12-20)

I really prefer to have both ports (3.4 and 4.0) for some time. Then users will have time to test and adopt to 4.0. But if you put 4.0 in to www/redmine without a huge warning you will break many user's Redmine instances because of uncompatible plugins.

I tested it again and now it works (no idea why), I will do now a test build and if everything is fine, I will commit it.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 28 2020, 4:09 PM
Closed by commit rP527337: Update to 4.0.6. (authored by mfechner). · Explain Why
This revision was automatically updated to reflect the committed changes.