Page MenuHomeFreeBSD
Differential D2360

vt(4): Simplify vt_fb vt_fb_bitblt_bitmap
ClosedPublic
Actions

Authored by emaste on Apr 24 2015, 2:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 29, 10:22 AM
Unknown Object (File)
Thu, Nov 27, 8:12 PM
Unknown Object (File)
Wed, Nov 26, 4:45 AM
Unknown Object (File)
Mon, Nov 24, 3:33 AM
Unknown Object (File)
Sat, Nov 22, 4:19 PM
Unknown Object (File)
Fri, Nov 21, 4:21 PM
Unknown Object (File)
Fri, Nov 21, 10:49 AM
Unknown Object (File)
Fri, Nov 21, 10:48 AM
View All Files
Subscribers
adrian
danfe

Details

Reviewers
dumbbell
ray
Commits
rS282247: vt: fix vt_fb_bitblt_bitmap mask corruption
Summary

This fixes mask corruption when the bitmap extends off the RHS of the window.

PR 199648
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199648

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 4976.Apr 24 2015, 2:48 AM
emaste retitled this revision from to vt(4): Simplify vt_fb vt_fb_bitblt_bitmap.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: dumbbell, ray.
emaste added a subscriber: adrian.Apr 24 2015, 3:09 PM
emaste added a subscriber: danfe.Apr 24 2015, 5:30 PM

I just discovered that this does not happen on stable/10. The latent bug here was exposed by r278673, which expanded the mouse pointer beyond 8 pixels wide. See D1801.

dumbbell accepted this revision.Apr 29 2015, 11:49 AM
dumbbell edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2015, 11:49 AM
Closed by commit rS282247: vt: fix vt_fb_bitblt_bitmap mask corruption (authored by emaste). · Explain WhyApr 29 2015, 8:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
vt/
hw/
fb/
54 lines

Diff 5091

View Options

head/sys/dev/vt/hw/fb/vt_fb.c

Loading...