vt(4): Simplify vt_fb vt_fb_bitblt_bitmap
ClosedPublic
Actions

Authored by emaste on Apr 24 2015, 2:48 AM.

Tags

None

Referenced Files

	F168176086: D2360.diff
	Wed, Aug 26, 5:38 PM

	F168142241: D2360.id4976.diff
	Wed, Aug 26, 1:59 PM

	Unknown Object (File)
	Tue, Aug 25, 5:37 PM

	Unknown Object (File)
	Wed, Aug 19, 5:32 PM

	Unknown Object (File)
	Tue, Aug 18, 9:55 AM

	Unknown Object (File)
	Tue, Aug 18, 9:54 AM

	Unknown Object (File)
	Tue, Aug 18, 9:53 AM

	Unknown Object (File)
	Thu, Aug 13, 9:38 PM

View All Files

Subscribers

adrian

danfe

Details

Reviewers

dumbbell
ray

Commits

rS282247: vt: fix vt_fb_bitblt_bitmap mask corruption

Summary

This fixes mask corruption when the bitmap extends off the RHS of the window.

PR 199648
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199648

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 4976.Apr 24 2015, 2:48 AM

emaste retitled this revision from to vt(4): Simplify vt_fb vt_fb_bitblt_bitmap.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: dumbbell, ray.

emaste added a subscriber: adrian.Apr 24 2015, 3:09 PM

I just discovered that this does not happen on stable/10. The latent bug here was exposed by r278673, which expanded the mouse pointer beyond 8 pixels wide. See D1801.

dumbbell accepted this revision.Apr 29 2015, 11:49 AM

dumbbell edited edge metadata.

This revision is now accepted and ready to land.Apr 29 2015, 11:49 AM

Closed by commit rS282247: vt: fix vt_fb_bitblt_bitmap mask corruption (authored by emaste). · Explain WhyApr 29 2015, 8:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

vt/

hw/

fb/

vt_fb.c

54 lines

Diff 5091

View Options

head/sys/dev/vt/hw/fb/vt_fb.c

vt(4): Simplify vt_fb vt_fb_bitblt_bitmapClosedPublicActions