Page MenuHomeFreeBSD

O_SEARCH test: mark revokex an expected fail on NFS
ClosedPublic

Authored by kevans on Feb 7 2020, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 22 2024, 3:05 AM
Unknown Object (File)
Sep 21 2024, 2:31 PM
Unknown Object (File)
Sep 21 2024, 2:08 AM
Unknown Object (File)
Sep 20 2024, 8:43 PM
Unknown Object (File)
Sep 19 2024, 11:04 PM
Unknown Object (File)
Sep 19 2024, 3:25 PM
Unknown Object (File)
Sep 9 2024, 1:55 AM
Unknown Object (File)
Sep 8 2024, 4:00 PM
Subscribers

Details

Summary

The revokex test does not work when the scratch directory is created on NFS. Given the nature of NFS, it likely can never work without looking like a security hole since O_SEARCH would rely on the server knowing that the directory did have +x at the time of open and that it's OK for it to have been revoked based on POSIX specification for O_SEARCH.

This does mean that O_SEARCH is only partially functional on NFS in general, but I suspect the execute bit getting revoked in the process is likely not common.

I'm fairly certain of the above, but I'm including Rick to confirm that this isn't something that could be made to work in a reasonably portable manner.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 7 2020, 5:18 PM

I believe you are correct. NFS is not POSIX compliant, since it checks
permissions on read/readdir and not just open.

This revision was automatically updated to reflect the committed changes.