Page MenuHomeFreeBSD

Temporarily force IFF_NEEDSEPOCH until drivers have been resolved.
ClosedPublic

Authored by jeff on Feb 5 2020, 2:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 13 2024, 10:02 AM
Unknown Object (File)
Sep 21 2024, 11:06 AM
Unknown Object (File)
Sep 18 2024, 2:48 PM
Unknown Object (File)
Sep 18 2024, 6:10 AM
Unknown Object (File)
Sep 8 2024, 4:22 AM
Unknown Object (File)
Sep 6 2024, 2:43 AM
Unknown Object (File)
Aug 31 2024, 10:45 PM
Unknown Object (File)
Aug 30 2024, 1:19 PM
Subscribers

Details

Summary

There are some pending fixes to network taskqueue, callout, and some thread based packet handling. Until those are adequately reviewed flip the default back to acquiring epoch in ether_input(). This should be a minor performance penalty that ensures that no more broken drivers are encountered for now. Conveniently someone abstracted flag accesses so that I only had to stop drivers from unintentionally clearing the value in one place.

We have discussed this with a subset of core and we believe this will take some urgency out of the situation so that a more healthy technical discussion can take place.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

This is the least sucky way to fix much of the breakage as a stop gap to the final solution

This revision is now accepted and ready to land.Feb 5 2020, 3:49 AM
hselasky added inline comments.
sys/net/if.c
4158 ↗(On Diff #67808)

The "struct ifnet *" cast on ifp can be removed I think?