mixer: the cleanup function is not called and not needed
ClosedPublic
Actions

Authored by pizzamig on Feb 4 2020, 10:07 AM.

Details

Reviewers

0mp
kp

Commits

rS357619: mixer: call the cleanup function in a test

Summary

In the mixer test called set_empty_value, the cleanup function is not used
because no cleanup is needed. However the function is defined.
This patch will just remove it

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pizzamig created this revision.Feb 4 2020, 10:07 AM

Harbormaster completed remote builds in B29157: Diff 67769.Feb 4 2020, 10:07 AM

Yes, it should not be there.

This revision is now accepted and ready to land.Feb 4 2020, 10:43 AM

Hmm. I wonder if it's not better the actually add the cleanup call to the atf_test_case definition.
It's not needed if the test passes, but perhaps it makes sense to try to restore the volume if the test should fail.

Also, if we don't have the cleanup function, do we still need save_mixer_vol?

Well, if mixer vol "" is changing the volume as a result of a bug, than the restore_mixer_vol is the right thing to do.
0mp: what do you think?

In D23498#515798, @pizzamig wrote:

Well, if mixer vol "" is changing the volume as a result of a bug, than the restore_mixer_vol is the right thing to do.
0mp: what do you think?

@kp is right, this would be better.