ipfw: Add missing mention of RFC 6598/Carrier Grade NAT in ipfw_config_nat()
ClosedPublic
Actions

Authored by nc on Feb 1 2020, 2:44 AM.

Details

Reviewers

ae
melifaro
donner

Commits

rS357787: ipfw nat: add missing bits after r357092 (RFC 6598/Carrier Grade NAT)

Summary

ipfw: Add missing mention of RFC 6598/Carrier Grade NAT in ipfw_config_nat().

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

nc created this revision.Feb 1 2020, 2:44 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2020, 2:44 AM

nc edited the summary of this revision. (Show Details)Feb 1 2020, 2:46 AM

I wondered why there is no change in the man page necessary, but it was already mentioned.
I wondered why somebody would mention an option in the man page, but the code only covers the "read and show" part.
So this patch is to enable the functionality as described in the man page, correct?

Sorry for the late response, but yes, it is to fully enable the functionality.

nc mentioned this in D23450: libalias: Allow setting alias port ranges.Feb 8 2020, 7:47 PM

donner accepted this revision.Feb 8 2020, 8:12 PM

This revision is now accepted and ready to land.Feb 8 2020, 8:12 PM

pi added a subscriber: pi.Feb 9 2020, 7:58 AM

Closed by commit rS357787: ipfw nat: add missing bits after r357092 (RFC 6598/Carrier Grade NAT) (authored by eugen). · Explain WhyFeb 12 2020, 12:46 AM

This revision was automatically updated to reflect the committed changes.

eugen added a commit: rS357787: ipfw nat: add missing bits after r357092 (RFC 6598/Carrier Grade NAT).

eugen mentioned this in rS359694: MFC r357092,357787: Add support for RFC 6598/Carrier Grade NAT subnets.Apr 7 2020, 4:28 PM

eugen mentioned this in rS359695: MFC r357092,357787: Add support for RFC 6598/Carrier Grade NAT subnets.