Page MenuHomeFreeBSD
Differential D23363

Fix some misleading indentation warnings reported by recent clang.
ClosedPublic
Actions

Authored by jhb on Jan 25 2020, 12:54 PM.
Tags
None
Referenced Files
F136004981: D23363.id67314.diff
Sat, Nov 15, 12:26 AM
F136003745: D23363.id.diff
Sat, Nov 15, 12:11 AM
F135986721: D23363.id.diff
Fri, Nov 14, 8:29 PM
Unknown Object (File)
Fri, Nov 14, 2:09 AM
Unknown Object (File)
Fri, Nov 14, 1:53 AM
Unknown Object (File)
Mon, Nov 10, 4:48 AM
Unknown Object (File)
Sun, Oct 26, 2:33 AM
Unknown Object (File)
Wed, Oct 22, 12:23 PM
View All 71 Files
Subscribers
brooks
dim
imp

Details

Reviewers
kib
Commits
rS360305: MFC r357146 (partial, by jhb):
rS357146: Fix some misleading indentation warnings reported by recent clang.
Summary

These should not be any functional change. While the change in
emul10kx-pcm.c looks like a real bug fix (as opposed to inconsistent
whitespace), the extra statements were not harmful.

Test Plan
  • built a mips64 MALTA64 kernel with clang/llvm from early January

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jan 25 2020, 12:54 PM
Harbormaster completed remote builds in B28913: Diff 67286.Jan 25 2020, 12:54 PM
kib accepted this revision.Jan 25 2020, 1:13 PM
This revision is now accepted and ready to land.Jan 25 2020, 1:13 PM
Closed by commit rS357146: Fix some misleading indentation warnings reported by recent clang. (authored by jhb). · Explain WhyJan 26 2020, 2:21 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS357146: Fix some misleading indentation warnings reported by recent clang..
Herald added a subscriber: imp. · View Herald TranscriptJan 26 2020, 2:21 PM
imp added inline comments.Jan 26 2020, 5:16 PM
head/sys/kern/subr_stats.c
1588

Sent in email, but why do we no longer clear these bits?

imp added inline comments.Jan 26 2020, 5:29 PM
head/sys/kern/subr_stats.c
1588

Ah. See the new review to fix this so never mind

dim added a commit: rS360305: MFC r357146 (partial, by jhb):.Apr 25 2020, 1:18 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
mrsas/
15 lines
sound/
pci/
11 lines
3 lines
kern/
4 lines

Diff 67314

View Options

head/sys/dev/mrsas/mrsas_cam.c

Loading...
View Options

head/sys/dev/sound/pci/emu10k1.c

Loading...
View Options

head/sys/dev/sound/pci/emu10kx-pcm.c

Loading...
View Options

head/sys/kern/subr_stats.c

Loading...