Restructure fault to eliminate a goto and label.
ClosedPublic
Actions

Authored by jeff on Jan 22 2020, 7:23 PM.

Details

Reviewers

alc
dougm
kib
markj

Commits

rS357027: (fault 8/9) Restructure some code to reduce duplication and simplify flow

Summary

As Doug noticed this is a bit cleaner.

I could almost see making a vm_fault_object() call that wraps up the various stages in the loop but for now I'm reasonably happy with this.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jeff created this revision.Jan 22 2020, 7:23 PM

Harbormaster completed remote builds in B28849: Diff 67152.Jan 22 2020, 7:23 PM

jeff edited the summary of this revision. (Show Details)Jan 22 2020, 7:25 PM

jeff added reviewers: alc, dougm, kib, markj.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 22 2020, 7:25 PM

dougm accepted this revision.Jan 22 2020, 7:42 PM

This revision is now accepted and ready to land.Jan 22 2020, 7:42 PM

Note that the title of the review is misleading.

markj accepted this revision.Jan 22 2020, 8:40 PM

Closed by commit rS357027: (fault 8/9) Restructure some code to reduce duplication and simplify flow (authored by jeff). · Explain WhyJan 23 2020, 5:22 AM

This revision was automatically updated to reflect the committed changes.

jeff added a commit: rS357027: (fault 8/9) Restructure some code to reduce duplication and simplify flow.

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_fault.c

80 lines

Diff 67185

View Options

Restructure fault to eliminate a goto and label.ClosedPublicActions