Page MenuHomeFreeBSD

Move the backing_object chain traversal into its own function.
ClosedPublic

Authored by jeff on Jan 22 2020, 2:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 1:24 PM
Unknown Object (File)
Jan 8 2025, 1:23 AM
Unknown Object (File)
Nov 18 2024, 2:36 AM
Unknown Object (File)
Nov 13 2024, 12:11 AM
Unknown Object (File)
Oct 29 2024, 10:09 PM
Unknown Object (File)
Sep 30 2024, 6:16 AM
Unknown Object (File)
Sep 27 2024, 2:53 PM
Unknown Object (File)
Sep 26 2024, 12:52 PM
Subscribers

Details

Summary

This should be functionally identical. In a later diff I collapse the two calls to vm_object_next() into one.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jeff added reviewers: alc, dougm, kib, markj.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
sys/vm/vm_fault.c
964 ↗(On Diff #67130)

In retrospect it might end up making the locking more clear if I split the zero fill off. I would like to do that in a subsequent patch.

sys/vm/vm_fault.c
1193 ↗(On Diff #67130)

I perceive that the point of the next label before this change and the new function introduced in its stead is all to avoid wrapping lines 1267-1379 in a giant if (fs.object->type != OBJT_DEFAULT) {} block, with associated indentation, and all the line wrapping that would lead to. It seems that a function to wrap all that code would solve the same problem in a more direct way.

sys/vm/vm_fault.c
1193 ↗(On Diff #67130)

Yes definitely. a couple of diffs after this resolve this more cleanly. I just didn't want to post it all at once for fear of burning people out. I wanted to move the large blocks out whole before too much restructuring.

This revision is now accepted and ready to land.Jan 22 2020, 5:04 AM