Page MenuHomeFreeBSD

Move cow into its own function.
ClosedPublic

Authored by jeff on Tue, Jan 21, 7:55 PM.

Details

Summary

This one is straightforward because there are no failure cases in cow.

Throughout these patches I have left the faultcount and hardfault variables in the main function. It may be useful to move them into faultstate at some point.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jeff created this revision.Tue, Jan 21, 7:55 PM
jeff edited the summary of this revision. (Show Details)Tue, Jan 21, 7:57 PM
jeff added reviewers: alc, dougm, kib, markj.
jeff set the repository for this revision to rS FreeBSD src repository.
jeff added inline comments.Tue, Jan 21, 7:58 PM
sys/vm/vm_fault.c
871 ↗(On Diff #67116)

I shortened this chain of conditions because I had the horizontal space but also because I find these to be related concepts.

kib accepted this revision.Tue, Jan 21, 9:07 PM
kib added inline comments.
sys/vm/vm_fault.c
870 ↗(On Diff #67116)

Such comments could be changed to one-liner to further save the vertical space.

908 ↗(On Diff #67116)

I would reword this comment.

This revision is now accepted and ready to land.Tue, Jan 21, 9:07 PM
jeff added inline comments.Tue, Jan 21, 9:09 PM
sys/vm/vm_fault.c
908 ↗(On Diff #67116)

I general I find many of the historic comments are written in a more conversational and less professional style than we are tending towards. I would rather make a separate pass and evaluate comments together.

markj accepted this revision.Wed, Jan 22, 8:24 PM
markj added inline comments.
sys/vm/vm_fault.c
873 ↗(On Diff #67116)

Missing a period here.

This revision was automatically updated to reflect the committed changes.