Move cow into its own function.
ClosedPublic
Actions

Authored by jeff on Jan 21 2020, 7:55 PM.

Details

Reviewers

alc
dougm
kib
markj

Commits

rS357023: (fault 4/9) Move copy-on-write into a dedicated function.

Summary

This one is straightforward because there are no failure cases in cow.

Throughout these patches I have left the faultcount and hardfault variables in the main function. It may be useful to move them into faultstate at some point.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jeff created this revision.Jan 21 2020, 7:55 PM

Harbormaster completed remote builds in B28826: Diff 67116.Jan 21 2020, 7:55 PM

jeff edited the summary of this revision. (Show Details)Jan 21 2020, 7:57 PM

jeff added reviewers: alc, dougm, kib, markj.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 21 2020, 7:57 PM

jeff added inline comments.Jan 21 2020, 7:58 PM

sys/vm/vm_fault.c
871 ↗	(On Diff #67116)	I shortened this chain of conditions because I had the horizontal space but also because I find these to be related concepts.

kib accepted this revision.Jan 21 2020, 9:07 PM

kib added inline comments.

sys/vm/vm_fault.c
870 ↗	(On Diff #67116)	Such comments could be changed to one-liner to further save the vertical space.
908 ↗	(On Diff #67116)	I would reword this comment.

This revision is now accepted and ready to land.Jan 21 2020, 9:07 PM

jeff added inline comments.Jan 21 2020, 9:09 PM

sys/vm/vm_fault.c
908 ↗	(On Diff #67116)	I general I find many of the historic comments are written in a more conversational and less professional style than we are tending towards. I would rather make a separate pass and evaluate comments together.