Move readahead into its own function.
ClosedPublic
Actions

Authored by jeff on Jan 20 2020, 6:36 PM.

Details

Reviewers

alc
dougm
kib
markj

Commits

rS356936: Move readahead and dropbehind fault functionality into a helper routine for

Summary

This is simply moving functionality out of the main fault loop. I intend to continue to do so to simplify control flow and improve readability so that when I introduce lockless lookups we don't have spaghetti code of a dozen gotos.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jeff created this revision.Jan 20 2020, 6:36 PM

Harbormaster completed remote builds in B28792: Diff 67059.Jan 20 2020, 6:36 PM

jeff edited the summary of this revision. (Show Details)Jan 20 2020, 6:39 PM

jeff added reviewers: alc, dougm, kib, markj.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 20 2020, 6:39 PM

dougm accepted this revision.Jan 20 2020, 8:21 PM

This revision is now accepted and ready to land.Jan 20 2020, 8:21 PM

markj accepted this revision.Jan 20 2020, 8:48 PM

kib accepted this revision.Jan 20 2020, 9:23 PM

Closed by commit rS356936: Move readahead and dropbehind fault functionality into a helper routine for (authored by jeff). · Explain WhyJan 21 2020, 12:13 AM

This revision was automatically updated to reflect the committed changes.

jeff added a commit: rS356936: Move readahead and dropbehind fault functionality into a helper routine for.

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_fault.c

98 lines

Diff 67075

View Options

Move readahead into its own function.ClosedPublicActions