Page MenuHomeFreeBSD

net-mgmt/pmacct: Rework/fix plist logic
AbandonedPublic

Authored by otis_sk.freebsd.org on Jan 19 2020, 1:16 PM.

Details

Reviewers
pi
Summary

Fix substitution of SQLDOC in plist. Previously, SQLDOC was always overwritten to "@comment " by subsequent condition (except from the last one).

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29533
Build 27398: arc lint + arc unit

Event Timeline

  • net-mgmt/pmacct: Fix the SQLDOC substitution logic
otis_sk.freebsd.org updated this revision to Diff 67008.EditedJan 19 2020, 6:52 PM
  • net-mgmt/pmacct: Use also pkgconfig to help database library detection
  • Remove obsolete/unused options
  • net-mgmt/pmacct: Update Makefile

you could get rid of most of the if-fery

net-mgmt/pmacct/Makefile
35–36

why not

MYSQL_USES=mysql
MYSQL_CONFIGURE_ENABLE=mysql
48–49
MLAYER2_CONFIGURE_ENABLE=...
  • net-mgmt/pmacct: Rework port options a bit.
  • Rework options processing logic
otis_sk.freebsd.org marked an inline comment as done.Jan 23 2020, 10:35 PM

you could get rid of most of the if-fery

net-mgmt/pmacct/Makefile
48–49

WIthout leading M.

pi added a subscriber: pi.Sat, Feb 22, 4:47 PM
pi requested changes to this revision.Sat, Feb 22, 4:53 PM

I've tried to apply the diff, but it failed. Can you update the patch to the most recent version of the Makefile and
test, wether it applies ?

This revision now requires changes to proceed.Sat, Feb 22, 4:53 PM
otis_sk.freebsd.org marked an inline comment as done.

Fix plist logic and pgsql module

pi added a comment.Sun, Feb 23, 9:40 AM

Please check the diff again. I updated the port to 1.7.4p1 yesterday, and this diff does not look similar to your first version of the patch ?

New diff revision will be created.