net-mgmt/pmacct: Rework/fix plist logic

[otis]

Summary

Fix substitution of SQLDOC in plist. Previously, SQLDOC was always overwritten to "@comment " by subsequent condition (except from the last one).

[otis]

• net-mgmt/pmacct: Fix the SQLDOC substitution logic

[otis]

• net-mgmt/pmacct: Use also pkgconfig to help database library detection
• Remove obsolete/unused options

[diizzy]

Instead of defining localbase manually doesn't USES= localbase work?
https://www.freebsd.org/doc/en/books/porters-handbook/uses-localbase.html

[otis]

• net-mgmt/pmacct: Update Makefile

[tcberner]

you could get rid of most of the if-fery

net-mgmt/pmacct/Makefile

35–36

why not

MYSQL_USES=mysql
MYSQL_CONFIGURE_ENABLE=mysql

48–49

MLAYER2_CONFIGURE_ENABLE=...

[otis]

• net-mgmt/pmacct: Rework port options a bit.

[diizzy]

Instead of the IGNORE can't you use IMPLIES instead to avoid breakage?
https://svnweb.freebsd.org/ports/head/audio/cmus/Makefile?revision=519931&view=markup#l116

[otis]

• Rework options processing logic

[otis]

In D23261#510700, @tcberner wrote:

you could get rid of most of the if-fery

net-mgmt/pmacct/Makefile

48–49

WIthout leading M.

[pi]

I've tried to apply the diff, but it failed. Can you update the patch to the most recent version of the Makefile and
test, wether it applies ?

[otis]

Fix plist logic and pgsql module

[pi]

Please check the diff again. I updated the port to 1.7.4p1 yesterday, and this diff does not look similar to your first version of the patch ?

[otis]

New diff revision will be created.