Differential D23244

[PowerPC] Fix Book-E direct map for >=16G ram on e5500
ClosedPublic
Actions

Authored by bdragon on Jan 17 2020, 10:35 PM.

Details

Reviewers

jhibbits

Commits

rS356857: [PowerPC] Fix Book-E direct map for >=16G ram on e5500

Summary

It turns out the maximum TLB1 page size on e5500 is 4G, despite the format being defined for up to 1TB.

So, we need to clamp the DMAP TLB1 entries to not attempt to create 16G or larger entries.

Fixes boot on my X5000 in which I just installed 16G of RAM.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.Jan 17 2020, 10:35 PM

Herald added subscribers: alfredo, luporl, imp. · View Herald TranscriptJan 17 2020, 10:35 PM

jhibbits added inline comments.Jan 17 2020, 10:42 PM

sys/powerpc/booke/pmap.c
4031 ↗	(On Diff #66940)	You should move this down below, so that it gets 4GB clamped only after it gets alignment clamped.
4044 ↗	(On Diff #66940)	Down to here.

moving clamp down as per suggestion.

bdragon marked 2 inline comments as done.Jan 17 2020, 11:19 PM

bdragon added inline comments.Jan 18 2020, 12:52 AM

sys/powerpc/booke/pmap.c
4044 ↗	(On Diff #66942)	I need to hide this beind #ifdef powerpc64 to get it to compile.

Hide the clamping code behind powerpc64 so 32-bit booke compiles.

jhibbits accepted this revision.Jan 18 2020, 1:03 AM

This revision is now accepted and ready to land.Jan 18 2020, 1:03 AM

Closed by commit rS356857: [PowerPC] Fix Book-E direct map for >=16G ram on e5500 (authored by bdragon). · Explain WhyJan 18 2020, 1:23 AM

This revision was automatically updated to reflect the committed changes.

bdragon added a commit: rS356857: [PowerPC] Fix Book-E direct map for >=16G ram on e5500.

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

booke/

pmap.c

17 lines

Diff 66949

View Options

head/sys/powerpc/booke/pmap.c

[PowerPC] Fix Book-E direct map for >=16G ram on e5500ClosedPublicActions