Add compat.linux.ignore_ip_recverr sysctl
ClosedPublic
Actions

Authored by trasz on Jan 17 2020, 2:14 PM.

Details

Reviewers

dchagin
emaste

Group Reviewers

Linux Emulation

Commits

rS357202: Add compat.linux.ignore_ip_recverr sysctl. This is a workaround

Summary

Add compat.linux.ignore_ip_recverr sysctl. This is a workaround
for missing IP_RECVERR setsockopt(2) support. Without it, DNS
resolution is broken for glibc >= 2.30 (glibc BZ #24047).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28734
Build 26749: arc lint + arc unit

Event Timeline

trasz created this revision.Jan 17 2020, 2:14 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 17 2020, 2:14 PM

Harbormaster completed remote builds in B28734: Diff 66911.Jan 17 2020, 2:14 PM

trasz added reviewers: Linux Emulation, dchagin, emaste.Jan 17 2020, 2:14 PM

trasz edited the summary of this revision. (Show Details)Jan 17 2020, 2:43 PM

Why a sysctl for this one instead of just whine loudly and carry on like most other cases?

Because it would be way too verbose - it’s being used all the time, every time something attempts to resolve a name. The sysctl is just a debugging aid, in case it would break some use case.

(Also, I have another change that adds generic logging of unsupported options in setsockopt and getsockopt in the queue.)

Tinderboxed.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 28 2020, 1:52 PM

Closed by commit rS357202: Add compat.linux.ignore_ip_recverr sysctl. This is a workaround (authored by trasz). · Explain Why

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS357202: Add compat.linux.ignore_ip_recverr sysctl. This is a workaround.