Propose a way to specify all available cpus as net.isr.maxthreads.
ClosedPublic
Actions

Authored by hiren on Apr 17 2015, 8:10 PM.

Details

Reviewers

gnn
adrian
rwatson

Summary

Currently there is no easy way to specify net.isr.maxthreads = all cpus. We need to specify exact number of cpus in loader.conf which get annoying when you have mix of machines which don't have equal number of total cpus. I propose "-1" as that value. When loader.conf has net.isr.maxthreads = -1, netisr will use all available cpus.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

hiren updated this revision to Diff 4887.Apr 17 2015, 8:10 PM

hiren retitled this revision from to Propose a way to specify all available cpus as net.isr.maxthreads..

hiren updated this object.

hiren edited the test plan for this revision. (Show Details)

hiren added reviewers: adrian, gnn, rwatson.

hiren added a subscriber: network.

Herald added a subscriber: imp. · View Herald TranscriptApr 17 2015, 8:10 PM

Addressing offline comments by davide@ to do input validation for all possible values.
jhb@ mentioned that we can always set a high value like 255 in loader.conf and it'd be capped down to total cpus. I prefer the approach presented in this patch.

Update the comment block to specify new default value.

gnn accepted this revision.Apr 18 2015, 4:20 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Apr 18 2015, 4:20 PM

This has been committed.

Revision Contents
Changeset List

Path

Size

sys/

net/

netisr.c

15 lines

Diff 4889

View Options

Propose a way to specify all available cpus as net.isr.maxthreads.ClosedPublicActions