fstyp: fix Coverity issues in hammer support
ClosedPublic
Actions

Authored by vangyzen on Jan 13 2020, 9:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 10, 3:54 PM

	Unknown Object (File)
	Thu, May 9, 10:48 AM

	Unknown Object (File)
	Fri, May 3, 8:17 AM

	Unknown Object (File)
	Tue, Apr 30, 3:36 AM

	Unknown Object (File)
	Tue, Apr 30, 3:36 AM

	Unknown Object (File)
	Tue, Apr 30, 3:35 AM

	Unknown Object (File)
	Mon, Apr 29, 7:42 PM

	Unknown Object (File)
	Sat, Apr 20, 12:00 AM

Subscribers

Details

Reviewers

pfg

Commits

rS356709: fstyp hammer2: remove dead code
rS356708: fstyp hammer: use strlcpy

Summary

Use strlcpy to guarantee NUL termination. Due to this, there is
no need for strncmp; simply use strcmp.

CID: 1412242

best_i will always be >= 0, so remove code to test otherwise.

CID: 1412244

Test Plan

Untested.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28646
Build 26673: arc lint + arc unit

Event Timeline

vangyzen created this revision.Jan 13 2020, 9:21 PM

Herald added subscribers: dab, badger. · View Herald TranscriptJan 13 2020, 9:21 PM

Harbormaster completed remote builds in B28646: Diff 66702.Jan 13 2020, 9:21 PM

LGTM. I forwarded the revision link to Tomohiro Kusumi from DragonFly as well.

This revision is now accepted and ready to land.Jan 13 2020, 9:52 PM

Closed by commit rS356708: fstyp hammer: use strlcpy (authored by vangyzen). · Explain WhyJan 13 2020, 10:34 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rS356708: fstyp hammer: use strlcpy.

Herald added a subscriber: imp. · View Herald TranscriptJan 13 2020, 10:34 PM

vangyzen added a commit: rS356709: fstyp hammer2: remove dead code.Jan 13 2020, 10:36 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

fstyp/

hammer.c

4 lines

hammer2.c

5 lines

Diff 66702

View Options

usr.sbin/fstyp/hammer.c