Page MenuHomeFreeBSD

fstyp: fix Coverity issues in hammer support
ClosedPublic

Authored by vangyzen on Jan 13 2020, 9:21 PM.

Details

Summary

Use strlcpy to guarantee NUL termination. Due to this, there is
no need for strncmp; simply use strcmp.

CID: 1412242

best_i will always be >= 0, so remove code to test otherwise.

CID: 1412244

Test Plan

Untested.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 28646
Build 26673: arc lint + arc unit

Event Timeline

vangyzen created this revision.Jan 13 2020, 9:21 PM
pfg accepted this revision.Jan 13 2020, 9:52 PM

LGTM. I forwarded the revision link to Tomohiro Kusumi from DragonFly as well.

This revision is now accepted and ready to land.Jan 13 2020, 9:52 PM
This revision was automatically updated to reflect the committed changes.