fstyp: fix Coverity issues in hammer support
ClosedPublic
Actions

Authored by vangyzen on Jan 13 2020, 9:21 PM.

Tags

None

Referenced Files

	F166283048: D23159.diff
	Wed, Aug 12, 4:42 PM

	F166275923: D23159.id66706.diff
	Wed, Aug 12, 4:05 PM

	F166168067: D23159.id66706.diff
	Wed, Aug 12, 1:21 AM

	Unknown Object (File)
	Sun, Aug 9, 10:14 AM

	Unknown Object (File)
	Sun, Aug 9, 9:58 AM

	Unknown Object (File)
	Sun, Aug 9, 9:51 AM

	Unknown Object (File)
	Sat, Aug 8, 10:12 PM

	Unknown Object (File)
	Sun, Jul 26, 5:31 AM

Subscribers

Details

Reviewers

pfg

Commits

rS356709: fstyp hammer2: remove dead code
rS356708: fstyp hammer: use strlcpy

Summary

Use strlcpy to guarantee NUL termination. Due to this, there is
no need for strncmp; simply use strcmp.

CID: 1412242

best_i will always be >= 0, so remove code to test otherwise.

CID: 1412244

Test Plan

Untested.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vangyzen created this revision.Jan 13 2020, 9:21 PM

Herald added subscribers: dab, badger. · View Herald TranscriptJan 13 2020, 9:21 PM

Harbormaster completed remote builds in B28646: Diff 66702.Jan 13 2020, 9:21 PM

LGTM. I forwarded the revision link to Tomohiro Kusumi from DragonFly as well.

This revision is now accepted and ready to land.Jan 13 2020, 9:52 PM

Closed by commit rS356708: fstyp hammer: use strlcpy (authored by vangyzen). · Explain WhyJan 13 2020, 10:34 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rS356708: fstyp hammer: use strlcpy.

Herald added a subscriber: imp. · View Herald TranscriptJan 13 2020, 10:34 PM

vangyzen added a commit: rS356709: fstyp hammer2: remove dead code.Jan 13 2020, 10:36 PM

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

fstyp/

hammer.c

4 lines

Diff 66706

View Options

head/usr.sbin/fstyp/hammer.c

fstyp: fix Coverity issues in hammer supportClosedPublicActions