crunchide: always include both 32- and 64-bit ELF for cross builds
ClosedPublic
Actions

Authored by emaste on Apr 17 2015, 3:47 PM.

Details

Reviewers

• rodrigc
emaste
jhb
imp

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 4877.Apr 17 2015, 3:47 PM

emaste retitled this revision from to crunchide: always include both 32- and 64-bit ELF for cross builds.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: imp, • rodrigc, jhb.

imp added inline comments.Apr 17 2015, 4:11 PM

usr.sbin/crunch/crunchide/exec_elf32.c
181	While you are cleaning up, do we need all these ifndef for things that we define in the base?

emaste added inline comments.Apr 17 2015, 4:21 PM

usr.sbin/crunch/crunchide/exec_elf32.c
181	almost certainly not, but I'd rather do it as a subsequent commit

emaste accepted this revision.Apr 18 2015, 12:17 AM

emaste added a reviewer: emaste.

This revision is now accepted and ready to land.Apr 18 2015, 12:17 AM

Another possible cleanup would be to rename elf_exec32.c to elf_exec.c and have elf_exec32.c look like elf_exec64.c where both of them just set ELFSIZE and include the common file (this is what we do in other places). That would be a follow up though.

In D2314#8, @jhb wrote:

Another possible cleanup would be to rename elf_exec32.c to elf_exec.c and have elf_exec32.c look like elf_exec64.c where both of them just set ELFSIZE and include the common file (this is what we do in other places). That would be a follow up though.

Yeah. I recently discovered that NetBSD has a number of crunch* improvements, so we might want to look at importing it as vendor source, or cherry-pick changes from there.