sysutils/smartmontools: Update to 7.1
ClosedPublic
Actions

Authored by daniel.engberg.lists_pyret.net on Jan 9 2020, 9:06 AM.

Details

Reviewers

samm
otis

Commits

rP527607: sysutils/smartmontools: Update to 7.1

Summary

Update to smartmontools 7.1

Remove upstreamed patches
Remove gmake dependency
Remove drivedb update binary as it will modify tracked file drivedb.h

Test Plan

Build and run-time tested on 13-CURRENT (r356392)
Poudriere log{F6031662}

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

daniel.engberg.lists_pyret.net created this revision.Jan 9 2020, 9:06 AM

Herald added a subscriber: mat. · View Herald TranscriptJan 9 2020, 9:06 AM

@samm
Friendly ping

otis added a reviewer: otis.Feb 25 2020, 3:11 PM

jrm added a subscriber: jrm.Mar 2 2020, 1:42 AM

jrm added inline comments.

sysutils/smartmontools/Makefile
25–26 ↗	(On Diff #66541)	Could you give a brief summary describing why these were removed?

Oh, I see you did say Remove drivedb update binary as it will modify tracked files. Could you explain a bit what this means for someone not so familiar with the details here?

https://www.smartmontools.org/browser/trunk/smartmontools/update-smart-drivedb.8.in
This will overwrite drivedb.h causing a checksum mismatch.

daniel.engberg.lists_pyret.net edited the summary of this revision. (Show Details)Mar 2 2020, 2:08 AM

daniel.engberg.lists_pyret.net marked an inline comment as done.Mar 2 2020, 2:12 AM

daniel.engberg.lists_pyret.net added inline comments.

sysutils/smartmontools/Makefile
25–26 ↗	(On Diff #66541)	"GnuPG used to verify drivedb.h" https://www.smartmontools.org/browser/trunk/smartmontools/configure.ac Since we're not going to download (and update) drivedb.h I added it to avoid pulling in gnupg.