Fix bootstraping of crunchide

[• rodrigc]

Summary

When using an external gcc 4.9 toolchain on a FreeBSD 10.1 build host,
building of the CURRENT branch failed when trying to build rescue.

See this discussion:
https://lists.freebsd.org/pipermail/freebsd-toolchain/2015-April/001614.html
https://lists.freebsd.org/pipermail/freebsd-toolchain/2015-April/001616.html

[emaste]

Makefile.inc1

1469

I believe @imp suggested we still need it unconditionally when crossbuilding, and also note that usr.sbin/crunch is added for ${BOOTSTRAPPING} < 1000014 in bootstrap-tools. I wonder if we can just promote usr.sbin/crunch to an unconditional build tool?

[emaste]

In D2305#4, @emaste wrote:

I believe @imp suggested we still need it unconditionally when crossbuilding, and also note that usr.sbin/crunch is added for ${BOOTSTRAPPING} < 1000014 in bootstrap-tools. I wonder if we can just promote usr.sbin/crunch to an unconditional build tool?

Indeed, crunchide is built with only 32- or 64-bit ELF support depending on the target. I'll see about always compiling in both instead. If that works we can drop this part and change the ${BOOTSTRAPPING} test below. Or just make it unconditional below.

[imp]

I think that we've stumbled on more stuff we can just kill :)

Makefile.inc1

1469

I'd be inclined to promote it.

1470

Can you tell me where in the tree we define RELEASEDIR? Is it still even a thing?

1475

I'd love to know why this is needed.

(1) It is tiny, so building on 386 is fine, and the next line catches it.
(2) Cross building, the next line would catch it.

1476

Not withstanding my silly nitpicking above, I think this whole thing can be removed.
RELEASEDIR isn't defined anywhere
grep -r kgzip shows this is the only place that we build it or reference it in the tree
Therefore, since the witch weights the same as a duck, it is deadwood and can be burned.

[emaste]

_crunchide here is still needed for cross-builds (but should be addressed by D2314).
_crunch in the context not provided in this diff is the one that needs to be updated
I updated it in rS281659

[imp]

Makefile.inc1

1470

RELEASEDIR is detritus, so I removed it in D2313. It hasn't been a thing since FreeBSD 9's rewrite of the release process.

1476

kgzip is actually old, detritus, so I removed it in D2313.

[emaste]

This review can be abandoned - the original issue is now fixed.
We can open another review for a future change to make it unconditional.

[• rodrigc]

Fixed by rS281659