Preserve the inherited value of the status register in cpu_set_upcall().
ClosedPublic
Actions

Authored by jhb on Jan 6 2020, 8:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 8:06 AM

	Unknown Object (File)
	Sun, Dec 15, 8:04 AM

	Unknown Object (File)
	Sun, Dec 15, 8:03 AM

	Unknown Object (File)
	Sat, Nov 30, 5:56 PM

	Unknown Object (File)
	Oct 2 2024, 10:30 AM

	Unknown Object (File)
	Sep 21 2024, 6:13 AM

	Unknown Object (File)
	Sep 20 2024, 10:42 AM

	Unknown Object (File)
	Sep 20 2024, 10:13 AM

View All 32 Files

Subscribers

None

Details

Reviewers

brooks
kevans
jmallett
imp

Commits

rS356737: Preserve the inherited value of the status register in cpu_set_upcall().

Summary

Instead of re-deriving the value of SR using logic similar to
exec_set_regs(), just inherit the value from the existing thread
similar to fork().

Test Plan

tested mips64 under cheribsd

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 6 2020, 8:48 PM

Harbormaster completed remote builds in B28507: Diff 66422.Jan 6 2020, 8:48 PM

This probably fixes O32 binaries that use threads when run under an N64 kernel since the new threads would end up with UX set incorrectly today, but I didn't test that.

jhb added reviewers: jmallett, imp.Jan 13 2020, 10:16 PM

This seems sensible.

This revision is now accepted and ready to land.Jan 14 2020, 4:28 AM

Closed by commit rS356737: Preserve the inherited value of the status register in cpu_set_upcall(). (authored by jhb). · Explain WhyJan 14 2020, 6:00 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS356737: Preserve the inherited value of the status register in cpu_set_upcall()..

Revision Contents
Changeset List

Path

Size

head/

sys/

mips/

vm_machdep.c

16 lines

Diff 66746

View Options

head/sys/mips/mips/vm_machdep.c

Preserve the inherited value of the status register in cpu_set_upcall().ClosedPublicActions