Differential D22970

RISC-V: Don't hard-code field offsets of struct riscv_bootparams
ClosedPublic
Actions

Authored by jrtc27 on Dec 30 2019, 3:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 14, 10:22 AM

	Unknown Object (File)
	Feb 21 2025, 1:49 AM

	Unknown Object (File)
	Feb 20 2025, 2:02 AM

	Unknown Object (File)
	Feb 19 2025, 6:57 AM

	Unknown Object (File)
	Feb 18 2025, 3:14 PM

	Unknown Object (File)
	Feb 8 2025, 9:09 PM

	Unknown Object (File)
	Jan 11 2025, 12:44 AM

	Unknown Object (File)
	Dec 13 2024, 1:55 PM

View All 40 Files

Subscribers

Details

Reviewers

Commits

rS356205: Don't hard-code field offsets of struct riscv_bootparams.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Dec 30 2019, 3:12 PM

Harbormaster completed remote builds in B28380: Diff 66142.Dec 30 2019, 3:12 PM

br added inline comments.Dec 30 2019, 4:35 PM

sys/riscv/riscv/genassym.c
106 ↗	(On Diff #66142)	This line does not fit my terminal

Wrapped >80-character line.

Harbormaster completed remote builds in B28381: Diff 66144.Dec 30 2019, 4:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 30 2019, 5:19 PM

Closed by commit rS356205: Don't hard-code field offsets of struct riscv_bootparams. (authored by br). · Explain Why

This revision was automatically updated to reflect the committed changes.

br added a commit: rS356205: Don't hard-code field offsets of struct riscv_bootparams..

Herald added a subscriber: imp. · View Herald TranscriptDec 30 2019, 5:19 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

riscv/

6 lines

10 lines

Diff 66145

head/sys/riscv/riscv/genassym.c

	Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines
	int kern_ftruncate(struct thread *td, int fd, off_t length);			int kern_ftruncate(struct thread *td, int fd, off_t length);
	int kern_futimes(struct thread td, int fd, struct timeval tptr,			int kern_futimes(struct thread td, int fd, struct timeval tptr,
	enum uio_seg tptrseg);			enum uio_seg tptrseg);
	int kern_futimens(struct thread td, int fd, struct timespec tptr,			int kern_futimens(struct thread td, int fd, struct timespec tptr,
	enum uio_seg tptrseg);			enum uio_seg tptrseg);
	int kern_getdirentries(struct thread td, int fd, char buf, u_int count,			int kern_getdirentries(struct thread td, int fd, char buf, u_int count,
	long basep, ssize_t residp, enum uio_seg bufseg);			long basep, ssize_t residp, enum uio_seg bufseg);
	int kern_getfsstat(struct thread td, struct statfs *buf, size_t bufsize,			int kern_getfsstat(struct thread td, struct statfs *buf, size_t bufsize,
	enum uio_seg bufseg, int flags);			size_t *countp, enum uio_seg bufseg, int flags);
	int kern_getitimer(struct thread , u_int, struct itimerval );			int kern_getitimer(struct thread , u_int, struct itimerval );
	int kern_getppid(struct thread *);			int kern_getppid(struct thread *);
	int kern_getpeername(struct thread td, int fd, struct sockaddr *sa,			int kern_getpeername(struct thread td, int fd, struct sockaddr *sa,
	socklen_t *alen);			socklen_t *alen);
	int kern_getrusage(struct thread td, int who, struct rusage rup);			int kern_getrusage(struct thread td, int who, struct rusage rup);
	int kern_getsockname(struct thread td, int fd, struct sockaddr *sa,			int kern_getsockname(struct thread td, int fd, struct sockaddr *sa,
	socklen_t *alen);			socklen_t *alen);
	int kern_getsockopt(struct thread *td, int s, int level, int name,			int kern_getsockopt(struct thread *td, int s, int level, int name,
	▲ Show 20 Lines • Show All 125 Lines • Show Last 20 Lines

head/sys/riscv/riscv/locore.S

	Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Lines
	int kern_ftruncate(struct thread *td, int fd, off_t length);			int kern_ftruncate(struct thread *td, int fd, off_t length);
	int kern_futimes(struct thread td, int fd, struct timeval tptr,			int kern_futimes(struct thread td, int fd, struct timeval tptr,
	enum uio_seg tptrseg);			enum uio_seg tptrseg);
	int kern_futimens(struct thread td, int fd, struct timespec tptr,			int kern_futimens(struct thread td, int fd, struct timespec tptr,
	enum uio_seg tptrseg);			enum uio_seg tptrseg);
	int kern_getdirentries(struct thread td, int fd, char buf, u_int count,			int kern_getdirentries(struct thread td, int fd, char buf, u_int count,
	long basep, ssize_t residp, enum uio_seg bufseg);			long basep, ssize_t residp, enum uio_seg bufseg);
	int kern_getfsstat(struct thread td, struct statfs *buf, size_t bufsize,			int kern_getfsstat(struct thread td, struct statfs *buf, size_t bufsize,
	enum uio_seg bufseg, int flags);			size_t *countp, enum uio_seg bufseg, int flags);
	int kern_getitimer(struct thread , u_int, struct itimerval );			int kern_getitimer(struct thread , u_int, struct itimerval );
	int kern_getppid(struct thread *);			int kern_getppid(struct thread *);
	int kern_getpeername(struct thread td, int fd, struct sockaddr *sa,			int kern_getpeername(struct thread td, int fd, struct sockaddr *sa,
	socklen_t *alen);			socklen_t *alen);
	int kern_getrusage(struct thread td, int who, struct rusage rup);			int kern_getrusage(struct thread td, int who, struct rusage rup);
	int kern_getsockname(struct thread td, int fd, struct sockaddr *sa,			int kern_getsockname(struct thread td, int fd, struct sockaddr *sa,
	socklen_t *alen);			socklen_t *alen);
	int kern_getsockopt(struct thread *td, int s, int level, int name,			int kern_getsockopt(struct thread *td, int s, int level, int name,
	▲ Show 20 Lines • Show All 125 Lines • Show Last 20 Lines