Page MenuHomeFreeBSD

sysctlbyname(2): Remove temporary compatibility layer
ClosedPublic

Authored by kaktus on Dec 29 2019, 3:04 PM.
Tags
None
Referenced Files
F84564417: D22958.id66105.diff
Sat, May 25, 1:55 PM
Unknown Object (File)
Fri, May 24, 12:04 PM
Unknown Object (File)
Fri, May 24, 11:58 AM
Unknown Object (File)
Fri, May 24, 3:50 AM
Unknown Object (File)
Fri, May 24, 2:32 AM
Unknown Object (File)
Tue, May 21, 10:28 PM
Unknown Object (File)
Tue, May 21, 2:25 PM
Unknown Object (File)
Fri, May 10, 4:45 PM
Subscribers

Details

Summary

Remove temporary compatibility layer introduced in r351729. More that 3 months should be enough for everybody who runs HEAD to upgrade to the new kernel already.

Approved-by:
Reviewed-by:

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove the now unneeded include of libc_private.h too.

This revision is now accepted and ready to land.Dec 29 2019, 3:25 PM
imp requested changes to this revision.Dec 29 2019, 3:40 PM

Will this break stable/12 binaries on cuurent?

This revision now requires changes to proceed.Dec 29 2019, 3:40 PM

No. This was only in place to make sure people can rollback to older kernel without libc exploding.

mjg requested changes to this revision.Dec 29 2019, 3:55 PM
mjg accepted this revision.
% file 12.1/bin/df
12.1/bin/df: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 12.1, FreeBSD-style, stripped

% truss -o /dev/stdout ./12.1/bin/df -l | grep sysctlby
__sysctlbyname("vfs.conflist",12,0x0,0x7fffffffcdf8,0x0,0) = 0 (0x0)
__sysctlbyname("vfs.conflist",12,0x8006eb000,0x7fffffffcdf8,0x0,0) = 0 (0x0)

Ok. In that case we are good.

This revision is now accepted and ready to land.Dec 29 2019, 4:52 PM