Page MenuHomeFreeBSD
Differential D22890

Apply r355883 to i386
ClosedPublic
Actions

Authored by alc on Dec 20 2019, 7:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 24, 5:14 AM
Unknown Object (File)
Feb 4 2025, 4:30 PM
Unknown Object (File)
Jan 5 2025, 3:24 AM
Unknown Object (File)
Sep 23 2024, 5:48 AM
Unknown Object (File)
Sep 18 2024, 2:49 PM
Unknown Object (File)
Sep 15 2024, 10:33 PM
Unknown Object (File)
Sep 15 2024, 10:33 PM
Unknown Object (File)
Sep 15 2024, 10:33 PM
View All 45 Files
Subscribers
imp
pho

Details

Reviewers
kib
Commits
rS356168: Correctly implement PMAP_ENTER_NOREPLACE in pmap_enter_{l2,pde}() on kernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc created this revision.Dec 20 2019, 7:37 AM
alc added a comment.Dec 20 2019, 7:40 AM

Peter, can you please test this patch on i386?

pho added a comment.Dec 20 2019, 7:52 AM
In D22890#501069, @alc wrote:

Peter, can you please test this patch on i386?

Sure. Building it now.

kib added inline comments.Dec 20 2019, 3:07 PM
sys/i386/i386/pmap.c
3966 ↗(On Diff #65847)

I missed this previous time. Should this be !pmap_every_pte_zero() ?

alc updated this revision to Diff 65867.Dec 20 2019, 6:56 PM

Correct a mistakenly inverted condition.

alc marked an inline comment as done.Dec 20 2019, 6:58 PM
alc added inline comments.
sys/i386/i386/pmap.c
3966 ↗(On Diff #65847)

Yes, you are correct. I will commit the fix to amd64 and arm64 shortly.

kib accepted this revision.Dec 20 2019, 8:59 PM
This revision is now accepted and ready to land.Dec 20 2019, 8:59 PM
pho added a comment.Dec 22 2019, 7:52 AM

So far, I have seen two (unrelated?) problems while testing with D22890.65867.diff:
https://people.freebsd.org/~pho/stress/log/alc012.txt
https://people.freebsd.org/~pho/stress/log/alc013.txt
I have resumed the tests.

kib added a comment.Dec 23 2019, 2:55 AM
In D22890#501483, @pho wrote:

So far, I have seen two (unrelated?) problems while testing with D22890.65867.diff:
https://people.freebsd.org/~pho/stress/log/alc012.txt
https://people.freebsd.org/~pho/stress/log/alc013.txt
I have resumed the tests.

alc012 seems to be either KVA fragmentation or depletion.
alc013 should be not related, I will look into it later.

pho added a comment.Dec 23 2019, 12:25 PM

I completed testing D22890.65867.diff without seeing any problems. The test included a buildworld.

Closed by commit rS356168: Correctly implement PMAP_ENTER_NOREPLACE in pmap_enter_{l2,pde}() on kernel (authored by alc). · Explain WhyDec 29 2019, 5:36 AM
This revision was automatically updated to reflect the committed changes.
alc marked an inline comment as done.
alc added a commit: rS356168: Correctly implement PMAP_ENTER_NOREPLACE in pmap_enter_{l2,pde}() on kernel.
Herald added a subscriber: imp. · View Herald TranscriptDec 29 2019, 5:36 AM

Revision Contents
Changeset List

PathSize
head/
sys/
i386/
i386/
92 lines

Diff 66090

View Options

head/sys/i386/i386/pmap.c

Loading...