Page MenuHomeFreeBSD

Make linux(4) use kern_socketpair(9)
ClosedPublic

Authored by trasz on Dec 14 2019, 1:03 PM.

Details

Summary

Make linux(4) use kern_socketpair(9) instead of going through
sys_socketpair(). It's a cleanup; no functional changes.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trasz created this revision.Dec 14 2019, 1:03 PM
kib added inline comments.Dec 14 2019, 4:41 PM
sys/compat/linux/linux_socket.c
758 ↗(On Diff #65655)

Wrong indent.

770 ↗(On Diff #65655)

else is not needed. Is this correct, in fact ?

776 ↗(On Diff #65655)

Extra empty line.

782 ↗(On Diff #65655)

Same.

trasz updated this revision to Diff 66737.Jan 14 2020, 12:34 PM

Fix things pointed out by kib@.

trasz marked 4 inline comments as done.Jan 14 2020, 12:35 PM
kib accepted this revision.Jan 14 2020, 7:45 PM
kib added inline comments.
sys/compat/linux/linux_socket.c
766 ↗(On Diff #66737)

Does this sentence in comment still makes sense ?

While there, remove the blank line before the comment.

774 ↗(On Diff #66737)

sizeof(sv) is better IMO.

This revision is now accepted and ready to land.Jan 14 2020, 7:45 PM
This revision was automatically updated to reflect the committed changes.