Differential D22814

Make linux(4) use kern_socketpair(9)
ClosedPublic
Actions

Authored by trasz on Dec 14 2019, 1:03 PM.

Tags

None

Referenced Files

	F135952584: D22814.id65655.diff
	Fri, Nov 14, 12:29 PM

	F135950369: D22814.id66737.diff
	Fri, Nov 14, 11:56 AM

	Unknown Object (File)
	Wed, Oct 29, 4:45 AM

	Unknown Object (File)
	Wed, Oct 29, 4:44 AM

	Unknown Object (File)
	Wed, Oct 29, 4:44 AM

	Unknown Object (File)
	Wed, Oct 29, 4:44 AM

	Unknown Object (File)
	Tue, Oct 28, 10:33 PM

	Unknown Object (File)
	Fri, Oct 24, 5:32 PM

View All 76 Files

Subscribers

Details

Reviewers

dchagin
emaste
kib

Group Reviewers

Linux Emulation

Commits

rS357727: Make linux(4) use kern_socketpair(9) instead of going through

Summary

Make linux(4) use kern_socketpair(9) instead of going through
sys_socketpair(). It's a cleanup; no functional changes.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Dec 14 2019, 1:03 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 14 2019, 1:03 PM

Harbormaster completed remote builds in B28152: Diff 65655.Dec 14 2019, 1:03 PM

trasz added reviewers: Linux Emulation, dchagin, emaste, kib.Dec 14 2019, 1:04 PM

kib added inline comments.Dec 14 2019, 4:41 PM

sys/compat/linux/linux_socket.c
758 ↗	(On Diff #65655)	Wrong indent.
770 ↗	(On Diff #65655)	else is not needed. Is this correct, in fact ?
776 ↗	(On Diff #65655)	Extra empty line.
782 ↗	(On Diff #65655)	Same.

Fix things pointed out by kib@.

Harbormaster completed remote builds in B28662: Diff 66737.Jan 14 2020, 12:34 PM

trasz marked 4 inline comments as done.Jan 14 2020, 12:35 PM

kib accepted this revision.Jan 14 2020, 7:45 PM

kib added inline comments.

sys/compat/linux/linux_socket.c
766 ↗	(On Diff #66737)	Does this sentence in comment still makes sense ? While there, remove the blank line before the comment.
774 ↗	(On Diff #66737)	sizeof(sv) is better IMO.

This revision is now accepted and ready to land.Jan 14 2020, 7:45 PM

Closed by commit rS357727: Make linux(4) use kern_socketpair(9) instead of going through (authored by trasz). · Explain WhyFeb 10 2020, 1:24 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS357727: Make linux(4) use kern_socketpair(9) instead of going through.

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linux/

34 lines

Diff 68056

head/sys/compat/linux/linux_socket.c

Loading...