Page MenuHomeFreeBSD
Differential D22814

Make linux(4) use kern_socketpair(9)
ClosedPublic
Actions

Authored by trasz on Dec 14 2019, 1:03 PM.
Tags
None
Referenced Files
F171009673: D22814.diff
Tue, Sep 8, 4:18 AM
Unknown Object (File)
Mon, Sep 7, 10:14 PM
Unknown Object (File)
Mon, Sep 7, 7:54 PM
Unknown Object (File)
Mon, Sep 7, 7:53 PM
Unknown Object (File)
Mon, Sep 7, 7:52 PM
Unknown Object (File)
Mon, Sep 7, 7:34 PM
Unknown Object (File)
Sun, Aug 23, 11:49 PM
Unknown Object (File)
Sat, Aug 22, 6:21 PM
View All Files
Subscribers
imp

Details

Reviewers
dchagin
emaste
kib
Group Reviewers
Linux Emulation
Commits
rS357727: Make linux(4) use kern_socketpair(9) instead of going through
Summary

Make linux(4) use kern_socketpair(9) instead of going through
sys_socketpair(). It's a cleanup; no functional changes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Dec 14 2019, 1:03 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 14 2019, 1:03 PM
Harbormaster completed remote builds in B28152: Diff 65655.Dec 14 2019, 1:03 PM
trasz added reviewers: Linux Emulation, dchagin, emaste, kib.Dec 14 2019, 1:04 PM
kib added inline comments.Dec 14 2019, 4:41 PM
sys/compat/linux/linux_socket.c
758 ↗(On Diff #65655)

Wrong indent.

770 ↗(On Diff #65655)

else is not needed. Is this correct, in fact ?

776 ↗(On Diff #65655)

Extra empty line.

782 ↗(On Diff #65655)

Same.

trasz updated this revision to Diff 66737.Jan 14 2020, 12:34 PM

Fix things pointed out by kib@.

Harbormaster completed remote builds in B28662: Diff 66737.Jan 14 2020, 12:34 PM
trasz marked 4 inline comments as done.Jan 14 2020, 12:35 PM
kib accepted this revision.Jan 14 2020, 7:45 PM
kib added inline comments.
sys/compat/linux/linux_socket.c
766 ↗(On Diff #66737)

Does this sentence in comment still makes sense ?

While there, remove the blank line before the comment.

774 ↗(On Diff #66737)

sizeof(sv) is better IMO.

This revision is now accepted and ready to land.Jan 14 2020, 7:45 PM
Closed by commit rS357727: Make linux(4) use kern_socketpair(9) instead of going through (authored by trasz). · Explain WhyFeb 10 2020, 1:24 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS357727: Make linux(4) use kern_socketpair(9) instead of going through.

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
linux/
34 lines

Diff 68056

View Options

head/sys/compat/linux/linux_socket.c

Loading...