Page MenuHomeFreeBSD

devel/sope4: fix libiconv
Needs ReviewPublic

Authored by otis_sk.freebsd.org on Dec 13 2019, 10:00 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lwhsu added a subscriber: lwhsu.Dec 15 2019, 11:39 PM

I guess this change needs bump PORTREVISION?

bapt added a subscriber: bapt.Dec 16 2019, 8:31 AM
bapt added inline comments.
devel/sope4/Makefile
18

there is a USES to deal with iconv dependency in a precise way

The main reason is that sope4 without any zeroconf mechanisms (either avahi or mdns) does not pull in libiconv while it is still being referenced in makefiles.

poudriere log with avahi:
https://pdr1.wilbury.net/data/12_STABLE_amd64-default/2019-12-21_14h26m18s/logs/sope4-4.2.0.log

Poudriere log without avahi:
https://pdr1.wilbury.net/data/12_STABLE_amd64-default-ns2/2019-12-21_14h15m02s/logs/errors/sope4-4.2.0.log

The other possible solution would be to tweak sope-core/NGExtensions/GNUmakefile.preamble to not depend upon -liconv on FreeBSD.

devel/sope4/Makefile
18

Yes, but sope4 still refers to the external one. The other way around would be to patch the build bits to not look for -liconv or better, to find out why is it still trying to use -liconv