[PowerPC] Fix powerpc 32 bit build in mmu_oea64.c
ClosedPublic
Actions

Authored by bdragon on Dec 12 2019, 3:55 PM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Aug 18, 4:41 AM

	Unknown Object (File)
	Tue, Aug 11, 8:14 AM

	Unknown Object (File)
	Mon, Aug 10, 2:23 PM

	Unknown Object (File)
	Mon, Aug 10, 1:54 PM

	Unknown Object (File)
	Sat, Aug 8, 6:56 PM

	Unknown Object (File)
	Thu, Aug 6, 9:25 PM

	Unknown Object (File)
	Wed, Aug 5, 8:45 AM

	Unknown Object (File)
	Wed, Aug 5, 3:31 AM

Subscribers

Details

Reviewers

jhibbits

Commits

rS355655: [PowerPC] Fix powerpc 32 bit build in mmu_oea64.c

Summary

Due to ppc32 building mmu_oea64.c (for use when in bridge mode on a G5), we need to guard the new moea64_page_array_startup code behind #ifdef powerpc64 to avoid a compile error, since vm_offset_t is not 64-bit on ppc32.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.Dec 12 2019, 3:55 PM

Herald added subscribers: alfredo, luporl, imp. · View Herald TranscriptDec 12 2019, 3:55 PM

jhibbits added inline comments.Dec 12 2019, 4:16 PM

sys/powerpc/aim/mmu_oea64.c
3056 ↗	(On Diff #65548)	This should be moved up around moea64_map_range(), since that's only used by this function.

address comment

bdragon marked an inline comment as done.Dec 12 2019, 4:43 PM

Sorry for the breakage.

This revision is now accepted and ready to land.Dec 12 2019, 4:44 PM

Closed by commit rS355655: [PowerPC] Fix powerpc 32 bit build in mmu_oea64.c (authored by bdragon). · Explain WhyDec 12 2019, 4:50 PM

This revision was automatically updated to reflect the committed changes.

bdragon added a commit: rS355655: [PowerPC] Fix powerpc 32 bit build in mmu_oea64.c.

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

aim/

mmu_oea64.c

6 lines

Diff 65551

View Options

head/sys/powerpc/aim/mmu_oea64.c

[PowerPC] Fix powerpc 32 bit build in mmu_oea64.cClosedPublicActions