[PowerPC] Fully define gdtoa settings on powerpc64.
ClosedPublic
Actions

Authored by bdragon on Dec 12 2019, 12:55 AM.

Tags

Referenced Files

	F103212147: D22775.diff
	Fri, Nov 22, 7:10 AM

	F103212136: D22775.diff
	Fri, Nov 22, 7:10 AM

	Unknown Object (File)
	Tue, Nov 19, 10:24 AM

	Unknown Object (File)
	Fri, Nov 8, 6:03 AM

	Unknown Object (File)
	Wed, Oct 30, 9:47 AM

	Unknown Object (File)
	Mon, Oct 28, 8:50 AM

	Unknown Object (File)
	Oct 20 2024, 9:06 AM

	Unknown Object (File)
	Oct 20 2024, 9:06 AM

Subscribers

Details

Reviewers

jhibbits

Commits

rS355729: [PowerPC] Fully define gdtoa settings on powerpc64.

Summary

The settings in arith.h were not fully defined on powerpc64 after the gdtoa switchover. Generate the missing settings using arithchk.c, similar to what amd64 did for rS114814.

Test Plan

Run kyua test in (at least) /usr/test/lib/libc/stdio.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.Dec 12 2019, 12:55 AM

Herald added subscribers: alfredo, luporl, imp. · View Herald TranscriptDec 12 2019, 12:55 AM

It looks to me like these are unnecessary. Grep is showing they're unused (except Long, but that's typedef'd automatically already).

lib/libc/powerpc64/arith.h
19 ↗	(On Diff #65519)	This is already present.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 13 2019, 8:30 PM

Closed by commit rS355729: [PowerPC] Fully define gdtoa settings on powerpc64. (authored by bdragon). · Explain Why

This revision was automatically updated to reflect the committed changes.

bdragon added a commit: rS355729: [PowerPC] Fully define gdtoa settings on powerpc64..

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

powerpc64/

arith.h

3 lines

Diff 65620

View Options

head/lib/libc/powerpc64/arith.h

[PowerPC] Fully define gdtoa settings on powerpc64.ClosedPublicActions