Page MenuHomeFreeBSD
Differential D22753

Implement atomic state updates using the new vm_page_astate_t structure.
ClosedPublic
Actions

Authored by markj on Dec 10 2019, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 11, 3:16 PM
Unknown Object (File)
Mon, Aug 10, 2:20 PM
Unknown Object (File)
Mon, Aug 10, 2:13 PM
Unknown Object (File)
Mon, Aug 10, 2:13 PM
Unknown Object (File)
Sun, Aug 9, 4:01 AM
Unknown Object (File)
Fri, Aug 7, 5:57 AM
Unknown Object (File)
Mon, Aug 3, 9:42 PM
Unknown Object (File)
Sun, Aug 2, 2:51 AM
View All Files
Subscribers
imp

Details

Reviewers
alc
kib
dougm
jeff
Commits
rS355672: Implement atomic state updates using the new vm_page_astate_t structure.
Summary

Introduce primitives vm_page_astate_load() and vm_page_astate_fcmpset()
to operate on the 32-bit per-page atomic state. Modify
vm_page_pqstate_fcmpset() to use them. No functional change intended.

Introduce PGA_QUEUE_OP_MASK, a subset of PGA_QUEUE_STATE_MASK that only
includes queue operation flags. This will be used in subsequent
patches.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Dec 10 2019, 7:11 PM
Harbormaster completed remote builds in B28066: Diff 65465.Dec 10 2019, 7:11 PM
markj added reviewers: alc, kib, dougm, jeff.Dec 10 2019, 7:12 PM
jeff added a comment.Dec 10 2019, 8:26 PM

Looks much nicer!

sys/vm/vm_page.h
759 ↗(On Diff #65465)

Shouldn't this be * NBBY?

markj updated this revision to Diff 65493.Dec 11 2019, 3:04 PM
markj marked an inline comment as done.

Fix the aflags shift definition, which happened to work regardless on
little-endian systems.

Harbormaster completed remote builds in B28079: Diff 65493.Dec 11 2019, 3:05 PM
kib accepted this revision.Dec 11 2019, 10:03 PM
This revision is now accepted and ready to land.Dec 11 2019, 10:03 PM
alc accepted this revision.Dec 12 2019, 8:27 AM
Closed by commit rS355672: Implement atomic state updates using the new vm_page_astate_t structure. (authored by markj). · Explain WhyDec 12 2019, 9:13 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS355672: Implement atomic state updates using the new vm_page_astate_t structure..
Herald added a subscriber: imp. · View Herald TranscriptDec 12 2019, 9:13 PM

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
77 lines

Diff 65565

View Options

head/sys/vm/vm_page.h

Loading...