Page MenuHomeFreeBSD

Eliminate lock recursion from turnstiles.
ClosedPublic

Authored by jeff on Dec 10 2019, 6:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 20, 7:07 PM
Unknown Object (File)
Thu, Nov 20, 7:06 PM
Unknown Object (File)
Thu, Nov 20, 7:00 PM
Unknown Object (File)
Thu, Nov 20, 6:50 PM
Unknown Object (File)
Fri, Nov 14, 7:05 AM
Unknown Object (File)
Thu, Nov 13, 2:00 PM
Unknown Object (File)
Thu, Nov 13, 1:46 PM
Unknown Object (File)
Thu, Nov 13, 1:42 PM
Subscribers

Details

Summary

This avoids the one place we recursively lock turnstiles. In highly contended workloads the recursive locking actually imposes a performance penalty. We trade failed atomic cmpsets and multiple modifications to the lock cacheline for a few pointer comparisons.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jeff added reviewers: jhb, kib, mav.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
This revision is now accepted and ready to land.Dec 10 2019, 2:42 PM
This revision was automatically updated to reflect the committed changes.
jeff added a commit: rS355782: schedlock 3/4.