Handle pagein clustering for vm_page_grab_valid() so that exec can use it.
ClosedPublic
Actions

Authored by jeff on Dec 8 2019, 2:06 AM.

Details

Reviewers

alc
dougm
kib
markj

Commits

rS355763: Handle pagein clustering in vm_page_grab_valid() so that it can be used by

Summary

This should be a functional NOP. It will allow for other vm_page_grab_valid() consumers to prefetch pages but more importantly it decreases the surface area for upcoming changes and reduces the amount of complicated VM code floating around in kern/*.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jeff created this revision.Dec 8 2019, 2:06 AM

Harbormaster completed remote builds in B28037: Diff 65397.Dec 8 2019, 2:06 AM

jeff edited the summary of this revision. (Show Details)Dec 8 2019, 2:10 AM

jeff added reviewers: alc, dougm, kib, markj.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptDec 8 2019, 2:10 AM

kib accepted this revision.Dec 8 2019, 5:47 PM

This revision is now accepted and ready to land.Dec 8 2019, 5:47 PM

alc added inline comments.Dec 9 2019, 4:32 PM

sys/vm/vm_page.c
4340–4342 ↗	(On Diff #65397)	This needs to say that flags, like VM_ALLOC_WIRED, won't affect the additional pages. It's not going to be obvious to everyone.