Page MenuHomeFreeBSD

[New Port] math/R-cran-alabama: Constrained Nonlinear Optimization
ClosedPublic

Authored by dteske on Dec 4 2019, 4:51 PM.

Details

Summary

Augmented Lagrangian Adaptive Barrier Minimization Algorithm (ALABAMA) for
optimizing smooth nonlinear objective functions in R with constraints.

Test Plan

install, deinstall, package, pkg install, pkg delete

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Drop Makefile change from review (done by addport)

assuming it passed portlint and this was part of a poudriere build, it looks ready.

This revision is now accepted and ready to land.Dec 4 2019, 6:51 PM

Remove extra newline per-mat

This revision now requires review to proceed.Dec 4 2019, 6:53 PM
mat requested changes to this revision.Dec 4 2019, 8:02 PM
mat added inline comments.
math/R-cran-alabama/Makefile
5–6 ↗(On Diff #65231)

Was this even tested ?
You can only set ONE out of PORTVERSION or DISTVERSION.

This revision now requires changes to proceed.Dec 4 2019, 8:02 PM
math/R-cran-alabama/Makefile
5–6 ↗(On Diff #65231)

Of COURSE it was tested.

You cannot have PORTVERSION with a dash (-) or underscore (_).

I did not know DISTVERSION was even a thing, I just created a variable to use in the DISTNAME setting because we cannot use PORTVERSION in DISTNAME because ports doesn't allow PORTVERSION to contain dash or underscore.

This revision now requires review to proceed.Dec 4 2019, 8:23 PM
mat requested changes to this revision.Dec 4 2019, 8:34 PM
mat added a subscriber: mat.
mat added inline comments.
math/R-cran-alabama/Makefile
5–6 ↗(On Diff #65231)

Well, if you test this, as is, it will fail in a very early stage with this error:

Defining both PORTVERSION and DISTVERSION is wrong, only set one, if necessary, set DISTNAME
This revision now requires changes to proceed.Dec 4 2019, 8:34 PM
math/R-cran-alabama/Makefile
5–6 ↗(On Diff #65231)

I can find no such error...

dteske@scribe12 R-cran-alabama $ make
===>  License GPLv2+ accepted by the user
===>   R-cran-alabama-2015.3.1 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by R-cran-alabama-2015.3.1 for building
===>  Extracting for R-cran-alabama-2015.3.1
=> SHA256 Checksum OK for alabama_2015.3-1.tar.gz.
===>  Patching for R-cran-alabama-2015.3.1
===>   R-cran-alabama-2015.3.1 depends on package: R-cran-numDeriv>0 - found
===>   R-cran-alabama-2015.3.1 depends on file: /usr/local/bin/R - found
===>  Configuring for R-cran-alabama-2015.3.1
===>  Staging for R-cran-alabama-2015.3.1
===>   R-cran-alabama-2015.3.1 depends on package: R-cran-numDeriv>0 - found
===>   R-cran-alabama-2015.3.1 depends on file: /usr/local/bin/R - found
===>   Generating temporary packing list
* installing *source* package 'alabama' ...
** package 'alabama' successfully unpacked and MD5 sums checked
** using staged installation
** R
** demo
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (alabama)
====> Compressing man pages (compress-man)
dteske@scribe12 R-cran-alabama $ make install
===>  Installing for R-cran-alabama-2015.3.1
===>  Checking if R-cran-alabama is already installed
===>  Switching to root credentials for 'install' target
Password:
===>   Registering installation for R-cran-alabama-2015.3.1
Installing R-cran-alabama-2015.3.1...
===>  Returning to user credentials
dteske@scribe12 R-cran-alabama $ make deinstall
===>  Switching to root credentials for 'deinstall' target
Password:
===>  Deinstalling for R-cran-alabama
===>   Deinstalling R-cran-alabama-2015.3.1
Updating database digests format: 100%
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	R-cran-alabama-2015.3.1

Number of packages to be removed: 1
[1/1] Deinstalling R-cran-alabama-2015.3.1...
[1/1] Deleting files for R-cran-alabama-2015.3.1: 100%
===>  Returning to user credentials
dteske@scribe12 R-cran-alabama $ make package
===>  Building package for R-cran-alabama-2015.3.1
math/R-cran-alabama/Makefile
5–6 ↗(On Diff #65231)

You need to have DEVELOPER=yes in your /etc/make.conf.

Even better, your tests should always be in poudriere, not form the shell. What it does from the shell is secondary to what it does in poudriere testport.

math/R-cran-alabama/Makefile
5–6 ↗(On Diff #65231)

(If you want a hand getting poudriere up and running, let me know.)

math/R-cran-alabama/Makefile
5–6 ↗(On Diff #65231)

I do not use poudriere

math/R-cran-alabama/Makefile
5–6 ↗(On Diff #65231)

These days, it is essential that ports be tested with poudriere testport. It is the single most powerful QA tool that we have, and because it's what the builders use, it's the only way of verifying that the packages will build. I highly recommend deploying a simple poudriere instance to facilitate ports development.

This revision is now accepted and ready to land.Dec 6 2019, 5:30 PM