Fix a bug with duplicate sysctl names.
ClosedPublic
Actions

Authored by jeff on Dec 3 2019, 9:56 PM.

Details

Reviewers

markj
pho
rlibby

Commits

rS355517: Fix two problems with r355149. The sysctl name collision code assumed that

Summary

Use one greater than the highest observe count. This may inflate the numbers but it will not have duplicates. If you create 4bn zones ordered to inflate the numbers you can deal with the sysctl warnings.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jeff created this revision.Dec 3 2019, 9:56 PM

Harbormaster completed remote builds in B27922: Diff 65180.Dec 3 2019, 9:56 PM

jeff edited the summary of this revision. (Show Details)Dec 3 2019, 9:57 PM

jeff added reviewers: markj, pho, rlibby.

rlibby accepted this revision.Dec 3 2019, 11:43 PM

rlibby added inline comments.

sys/vm/uma_core.c
1895–1899 ↗	(On Diff #65180)	An alternative might be to make use of `snprintf(NULL, 0, fmt, ...);` to count. (Or, maybe we ought to provide `int asprintf(char *p, struct malloc_type , const char *fmt, ...)`.)