Add kern_unmount() and use in Linuxulator. No functional changes.
Details
Details
- Reviewers
kib - Group Reviewers
Linux Emulation - Commits
- rS357075: Add kern_unmount() and use in Linuxulator. No functional changes.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 27912 Build 26081: arc lint + arc unit
Event Timeline
sys/compat/linux/linux_file.c | ||
---|---|---|
1064 | I am sure that it is not correct. Can we remove this function instead ? |
sys/compat/linux/linux_file.c | ||
---|---|---|
1064 | Not really, it's the Linux's main umount2(2) syscall. Should be fixed, though. |
sys/compat/linux/linux_file.c | ||
---|---|---|
1063–1064 | Don't you need to check other flags and at least log if anything is set ? |
sys/compat/linux/linux_file.c | ||
---|---|---|
1063–1064 | Yeah, we can actually error out on unsupported ones. |
sys/compat/linux/linux_file.c | ||
---|---|---|
1064 | What about linux prefix translation ? I see that the old syscall code did not do that, why ? |
Comment Actions
Why would it? It doesn't make much sense; you want it to unmount what you pass as an argument, and not it's linuxulator counterpart. Besides; this is mostly for use inside jails/chroots.