Page MenuHomeFreeBSD
Differential D22646

Add kern_unmount(), use in Linuxulator
ClosedPublic
Actions

Authored by trasz on Dec 3 2019, 5:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 4:46 AM
Unknown Object (File)
Sun, Nov 17, 10:30 PM
Unknown Object (File)
Sat, Nov 16, 7:57 PM
Unknown Object (File)
Fri, Nov 15, 8:18 PM
Unknown Object (File)
Thu, Nov 14, 10:01 AM
Unknown Object (File)
Wed, Nov 13, 11:03 PM
Unknown Object (File)
Wed, Nov 13, 10:53 PM
Unknown Object (File)
Wed, Nov 13, 7:14 PM
View All 60 Files
Subscribers
imp

Details

Reviewers
kib
Group Reviewers
Linux Emulation
Commits
rS357075: Add kern_unmount() and use in Linuxulator. No functional changes.
Summary

Add kern_unmount() and use in Linuxulator. No functional changes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Dec 3 2019, 5:10 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 3 2019, 5:10 PM
Harbormaster completed remote builds in B27912: Diff 65165.Dec 3 2019, 5:11 PM
trasz added reviewers: Linux Emulation, kib.Dec 3 2019, 5:11 PM
kib added inline comments.Dec 3 2019, 5:26 PM
sys/compat/linux/linux_file.c
1064 ↗(On Diff #65165)

I am sure that it is not correct. Can we remove this function instead ?

trasz updated this revision to Diff 67043.Jan 20 2020, 12:30 PM

Regen.

Harbormaster completed remote builds in B28785: Diff 67043.Jan 20 2020, 12:30 PM
trasz marked an inline comment as done.Jan 20 2020, 12:30 PM
trasz added inline comments.
sys/compat/linux/linux_file.c
1064 ↗(On Diff #65165)

Not really, it's the Linux's main umount2(2) syscall. Should be fixed, though.

kib added inline comments.Jan 20 2020, 3:54 PM
sys/compat/linux/linux_file.c
1081 ↗(On Diff #67043)

Don't you need to check other flags and at least log if anything is set ?

trasz updated this revision to Diff 67093.Jan 21 2020, 9:55 AM
trasz marked an inline comment as done.

Detect unsupported flags.

Harbormaster completed remote builds in B28811: Diff 67093.Jan 21 2020, 9:55 AM
trasz marked an inline comment as done.Jan 21 2020, 9:56 AM
trasz added inline comments.
sys/compat/linux/linux_file.c
1081 ↗(On Diff #67043)

Yeah, we can actually error out on unsupported ones.

kib added inline comments.Jan 21 2020, 12:04 PM
sys/compat/linux/linux_file.c
1089 ↗(On Diff #67093)

What about linux prefix translation ? I see that the old syscall code did not do that, why ?

trasz marked an inline comment as done.Jan 21 2020, 6:13 PM

Why would it? It doesn't make much sense; you want it to unmount what you pass as an argument, and not it's linuxulator counterpart. Besides; this is mostly for use inside jails/chroots.

kib accepted this revision.Jan 21 2020, 7:58 PM
In D22646#510845, @trasz wrote:

Why would it? It doesn't make much sense; you want it to unmount what you pass as an argument, and not it's linuxulator counterpart. Besides; this is mostly for use inside jails/chroots.

Because this is the consistent behavior. BTW, linux_mount also needs the same fix.

This revision is now accepted and ready to land.Jan 21 2020, 7:58 PM
Closed by commit rS357075: Add kern_unmount() and use in Linuxulator. No functional changes. (authored by trasz). · Explain WhyJan 24 2020, 11:58 AM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS357075: Add kern_unmount() and use in Linuxulator. No functional changes..

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
linux/
18 lines
kern/
17 lines
sys/
1 line

Diff 67248

View Options

head/sys/compat/linux/linux_file.c

Loading...
View Options

head/sys/kern/vfs_mount.c

Loading...
View Options

head/sys/sys/syscallsubr.h

Loading...