Page MenuHomeFreeBSD

Improve EPOCH_TRACE
ClosedPublic

Authored by bz on Dec 3 2019, 2:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 22 2023, 9:23 PM
Unknown Object (File)
Nov 23 2023, 11:18 AM
Unknown Object (File)
Oct 12 2023, 12:52 AM
Unknown Object (File)
Sep 30 2023, 7:06 PM
Unknown Object (File)
Sep 8 2023, 10:50 AM
Unknown Object (File)
Sep 6 2023, 4:38 AM
Unknown Object (File)
Sep 6 2023, 4:36 AM
Unknown Object (File)
Sep 6 2023, 4:35 AM
Subscribers

Details

Summary
Two changes to EPOCH_TRACE:
(1) add a sysctl to surpress the backtrace from epoch_trace_report().
    Sometimes the log line for the recursion is enough and the
    backtrace massively spams the console.
(2) In order to be able to go without the backtrace do not only
    print where the previous occurance happened, but also where
    the current one happens.  That way we have file:line information
    for both and can look at them without the need for getting line
    numbers from a debugging tool.

Note: (2) now gives rather long lines. E.g.:
Recursively entering epoch Net preemptible at /sys/netinet6/ip6_output.c:415, previously entered at /sys/netinet6/mld6.c:2226
and even longer if your sources are inside a subdirectory.
I was contemplating adding a \n\t for the second half.
Leave a comment if you think that would be good.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 27907
Build 26077: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Dec 5 2019, 10:53 PM
This revision was automatically updated to reflect the committed changes.