mips busdma: bzero map on alloc
ClosedPublic
Actions

Authored by rlibby on Dec 3 2019, 6:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 16, 12:30 AM

	Unknown Object (File)
	Mon, Apr 13, 4:19 AM

	Unknown Object (File)
	Sun, Apr 12, 1:30 AM

	Unknown Object (File)
	Wed, Apr 8, 5:17 PM

	Unknown Object (File)
	Wed, Apr 8, 9:41 AM

	Unknown Object (File)
	Sun, Apr 5, 10:45 AM

	Unknown Object (File)
	Sun, Mar 29, 2:14 PM

	Unknown Object (File)
	Sat, Mar 28, 11:49 PM

Subscribers

Details

Reviewers

imp
• ian

Commits

rS355343: mips busdma: bzero map on alloc

Summary

Maps from the mips busdma dmamap_zone were not completely initialized.
In particular, pagesneeded and pagesreserved were not initialized. This
could cause a crash.

Remove some dead fields from mips struct bus_dmamap while here.

Reported by: brooks

Test Plan

make CROSS_TOOLCHAIN=mips64-gcc TARGET_ARCH=mips64 buildkernel KERNCONF=MALTA64
qemu-system-mips64 -M malta -kernel .../mips.mips64/sys/MALTA64/kernel -m 2048 -nographic

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Dec 3 2019, 6:55 AM

Harbormaster completed remote builds in B27903: Diff 65150.Dec 3 2019, 6:55 AM

Heh, looks like when this code was copied to mips, someone ignored my comment

It'll need platform-specific changes if this code is copied.

This revision is now accepted and ready to land.Dec 3 2019, 4:13 PM

Closed by commit rS355343: mips busdma: bzero map on alloc (authored by rlibby). · Explain WhyDec 3 2019, 5:44 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rS355343: mips busdma: bzero map on alloc.

Revision Contents
Changeset List

Path

Size

head/

sys/

mips/

busdma_machdep.c

7 lines

Diff 65167

View Options

head/sys/mips/mips/busdma_machdep.c

mips busdma: bzero map on allocClosedPublicActions