Page MenuHomeFreeBSD

sysutils/cmocka: Update cmocka from version 1.1.3 to 1.1.5
ClosedPublic

Authored by dteske on Mon, Dec 2, 4:29 AM.

Details

Summary

Update cmocka to latest version.

Test Plan

Install port. Check installed files. Uninstall.
Make package. Install package. Uninstall package.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dteske created this revision.Mon, Dec 2, 4:29 AM
imp accepted this revision.Mon, Dec 2, 6:08 AM
This revision is now accepted and ready to land.Mon, Dec 2, 6:08 AM
swills added a subscriber: swills.Mon, Dec 2, 2:38 PM
swills added inline comments.
sysutils/cmocka/Makefile
14 ↗(On Diff #65113)

Why :noninja here, it doesn't seem required?

dteske added inline comments.Mon, Dec 2, 3:02 PM
sysutils/cmocka/Makefile
14 ↗(On Diff #65113)

On 12.0-RELEASE attempting to compile without :noninja results in the following error:

[0/1] /usr/local/bin/cmake -S/home/dteske/src/freebsd/ports/sysutils/cmocka/work/cmocka-1.1.5 -B/home/dteske/src/freebsd/ports/sysutils/cmocka/work/.build
-- Configuring done
-- Generating done
-- Build files have been written to: /home/dteske/src/freebsd/ports/sysutils/cmocka/work/.build
ninja: error: manifest 'build.ninja' still dirty after 100 tries

===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /home/dteske/src/freebsd/ports/sysutils/cmocka
*** Error code 1

Stop.
make: stopped in /home/dteske/src/freebsd/ports/sysutils/cmocka
swills added inline comments.Mon, Dec 2, 3:10 PM
sysutils/cmocka/Makefile
14 ↗(On Diff #65113)

Strange, I'm not able to reproduce. Can you confirm what version of ninja you're using? I'm using ninja-1.9.0,2.

dteske added inline comments.Mon, Dec 2, 3:23 PM
sysutils/cmocka/Makefile
14 ↗(On Diff #65113)

ninja-1.9.0,2

swills added inline comments.Mon, Dec 2, 3:30 PM
sysutils/cmocka/Makefile
14 ↗(On Diff #65113)

My build was in a jail, so I thought maybe that may be the source of the difference, so I tried reproducing this on ref12-amd64 and wasn't able to reproduce there either. But ref12-amd64 is running 12-STABLE, so maybe it's only an issue for 12.0-RELEASE? Any ideas?

dteske added inline comments.Mon, Dec 2, 3:30 PM
sysutils/cmocka/Makefile
14 ↗(On Diff #65113)

In case it helps:

dteske@scribe12 devel > uname -a
FreeBSD scribe12 12.0-RELEASE FreeBSD 12.0-RELEASE r341666 GENERIC  amd64
swills added inline comments.Mon, Dec 2, 3:35 PM
sysutils/cmocka/Makefile
14 ↗(On Diff #65113)

I wonder if it's related to this issue:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239512

https://github.com/ninja-build/ninja/issues/1599

There seems to be an implication there that it's related to some sort of local issue, perhaps NFS or some sort of system time issue?

dteske added inline comments.Mon, Dec 2, 5:44 PM
sysutils/cmocka/Makefile
14 ↗(On Diff #65113)

It might be the date/time. Let me see if that fixes it.

dteske@scribe12 ~ > date
Tue Oct 29 05:36:17 UTC 2019
dteske updated this revision to Diff 65127.Mon, Dec 2, 5:54 PM

Remove noninja args to USES=cmake

Problem was date/time. We should discuss how we can improve error-
condition checking to alert the user of this condition since the
current error is not very forthcoming.

This revision now requires review to proceed.Mon, Dec 2, 5:54 PM
dteske marked 4 inline comments as done.Mon, Dec 2, 5:55 PM
dteske added inline comments.
sysutils/cmocka/Makefile
14 ↗(On Diff #65113)

It was the date/time.

We should potentially discuss adding some error checking to the cmake include under Mk/Uses to perhaps alert the user when the date/time is too far behind, since ninja doesn't like that.

swills accepted this revision.Mon, Dec 2, 6:09 PM

LGTM

This revision is now accepted and ready to land.Mon, Dec 2, 6:09 PM
dteske removed a reviewer: mat.Wed, Dec 4, 8:23 PM
dteske added a reviewer: mat.Thu, Dec 5, 1:57 AM
This revision was automatically updated to reflect the committed changes.