Fix a logic bug when "mask: contains a ?: operator.
ClosedPublic
Actions

Authored by brooks on Nov 27 2019, 5:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 13, 10:08 PM

	Unknown Object (File)
	Sun, May 10, 10:11 AM

	Unknown Object (File)
	Wed, May 6, 12:43 AM

	Unknown Object (File)
	Thu, Apr 30, 4:22 PM

	Unknown Object (File)
	Mon, Apr 27, 8:26 AM

	Unknown Object (File)
	Fri, Apr 17, 11:40 PM

	Unknown Object (File)
	Wed, Apr 15, 6:41 PM

	Unknown Object (File)
	Apr 12 2026, 1:50 PM

View All Files

Subscribers

imp

Details

Reviewers

bz
jhb
markj

Commits

rS355454: MFC r355139:
rS355453: MFC r355139:
rS355139: Fix a logic bug when "mask" contains a ?: operator.

Summary

Newer versions of clang warn that '&' evaluates before '?:'.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Nov 27 2019, 5:38 PM

Harbormaster completed remote builds in B27809: Diff 64950.Nov 27 2019, 5:38 PM

markj accepted this revision.Nov 27 2019, 6:13 PM

This revision is now accepted and ready to land.Nov 27 2019, 6:13 PM

Closed by commit rS355139: Fix a logic bug when "mask" contains a ?: operator. (authored by brooks). · Explain WhyNov 27 2019, 8:00 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS355139: Fix a logic bug when "mask" contains a ?: operator..

Herald added a subscriber: imp. · View Herald TranscriptNov 27 2019, 8:00 PM

I would have been tempted to put parents around all macro args while l was at it...

brooks added a commit: rS355453: MFC r355139:.Dec 6 2019, 5:58 PM

brooks added a commit: rS355454: MFC r355139:.Dec 6 2019, 6:15 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

bwn/

if_bwnvar.h

2 lines

Diff 64973

View Options

head/sys/dev/bwn/if_bwnvar.h

Fix a logic bug when "mask: contains a ?: operator.ClosedPublicActions